From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/64086 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: [dooglus@gmail.com: gnus-summary-limit-children limits maximum thread length] Date: Tue, 05 Dec 2006 19:47:24 -0500 Message-ID: Reply-To: rms@gnu.org NNTP-Posting-Host: dough.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: sea.gmane.org 1165366076 4845 80.91.229.10 (6 Dec 2006 00:47:56 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 6 Dec 2006 00:47:56 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 06 01:47:55 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by dough.gmane.org with esmtp (Exim 4.50) id 1Grkws-0007Xr-RY for ged-emacs-devel@m.gmane.org; Wed, 06 Dec 2006 01:47:47 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Grkws-0008CU-Bq for ged-emacs-devel@m.gmane.org; Tue, 05 Dec 2006 19:47:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Grkwc-0008As-KS for emacs-devel@gnu.org; Tue, 05 Dec 2006 19:47:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GrkwZ-000883-6V for emacs-devel@gnu.org; Tue, 05 Dec 2006 19:47:27 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GrkwX-00087o-Gi for emacs-devel@gnu.org; Tue, 05 Dec 2006 19:47:25 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GrkwX-0000PR-Ky for emacs-devel@gnu.org; Tue, 05 Dec 2006 19:47:25 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.52) id 1GrkwW-00057K-EZ; Tue, 05 Dec 2006 19:47:24 -0500 Original-To: emacs-devel@gnu.org, ding@gnus.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:63338 gmane.emacs.gnus.general:64086 Archived-At: This seems like a good change. Would someone please install it in Emacs? ------- Start of forwarded message ------- Date: Tue, 05 Dec 2006 13:01:24 +0100 From: Chris Moore To: emacs-pretest-bug@gnu.org Subject: gnus-summary-limit-children limits maximum thread length X-Spam-Status: No, score=1.9 required=5.0 tests=RCVD_BY_IP, RCVD_IN_BL_SPAMCOP_NET autolearn=no version=3.0.4 The definition of gnus-summary-limit-children locally binds max-lisp-eval-depth to 5000, even if it was previously higher than that. This makes it impossible to view long threads of messages. Better would be if it used 'max' to make sure it was only increasing the value, not decreasing it. The same goes for gnus-sort-threads(), if we're going to keep the recursive version: - ------------------------------------------------------------------------ - --- lisp/gnus/gnus-sum.el 2006-11-27 00:02:10.000000000 +0100 +++ /tmp/gnus-sum.el 2006-12-05 12:54:33.000000000 +0100 @@ -4561,7 +4561,7 @@ (if (not gnus-thread-sort-functions) threads (gnus-message 8 "Sorting threads...") - - (let ((max-lisp-eval-depth 5000)) + (let ((max-lisp-eval-depth (max 5000 max-lisp-eval-depth))) (prog1 (gnus-sort-threads-1 threads (gnus-make-sort-function gnus-thread-sort-functions)) @@ -8165,7 +8165,7 @@ ;; will really go down to a leaf article first, before slowly ;; working its way up towards the root. (when thread - - (let* ((max-lisp-eval-depth 5000) + (let* ((max-lisp-eval-depth (max 5000 max-lisp-eval-depth)) (children (if (cdr thread) (apply '+ (mapcar 'gnus-summary-limit-children - ------------------------------------------------------------------------ In GNU Emacs 22.0.91.19 (i686-pc-linux-gnu, GTK+ Version 2.8.20) of 2006-12-03 on chrislap X server distributor `The X.Org Foundation', version 11.0.70101000 configured using `configure '--with-gtk' '--with-xpm' '--with-jpeg' '--with-png' '--with-gif'' Important settings: value of $LC_ALL: en_GB.UTF-8 value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_GB.UTF-8 locale-coding-system: utf-8 default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: show-paren-mode: t display-time-mode: t iswitchb-mode: t dynamic-completion-mode: t shell-dirtrack-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t unify-8859-on-encoding-mode: t utf-translate-cjk-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t _______________________________________________ emacs-pretest-bug mailing list emacs-pretest-bug@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug ------- End of forwarded message -------