Gnus development mailing list
 help / color / mirror / Atom feed
From: Richard Stallman <rms@gnu.org>
To: Reiner Steib <Reiner.Steib@gmx.de>
Cc: dann@ics.uci.edu, ding@gnus.org
Subject: Re: Warning: `mapcar' called for effect; use `mapc' or `dolist'
Date: Tue, 23 Oct 2007 06:39:11 -0400	[thread overview]
Message-ID: <E1IkHAF-00040s-KJ@fencepost.gnu.org> (raw)
In-Reply-To: <v93aw2amym.fsf@marauder.physik.uni-ulm.de> (message from Reiner Steib on Mon, 22 Oct 2007 22:55:29 +0200)

    >   > (defun gnus-group-highlight-line ()
    >   >   "Highlight the current line according to `gnus-group-highlight'."
    [...]
    > It seems that `mailp' is not used in that function. 

    `mailp' is used implicitly through the variable `gnus-group-highlight'
    which is let-bound to `list'.  `list' is used in the body of the
    let-form.

That code is a terrible crock.  Would you please rewrite it to make it
clearer?

I added a `risky-local-variable' property to `gnus-group-highlight'.
Are there any other such variables in Gnus which contain forms to
evaluate?



  parent reply	other threads:[~2007-10-23 10:39 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-20  6:43 Dan Nicolaescu
2007-10-22 12:13 ` Katsumi Yamaoka
2007-10-22 18:49   ` Reiner Steib
2007-10-22 20:07     ` Dan Nicolaescu
2007-10-22 20:55       ` Reiner Steib
2007-10-22 21:04         ` Dan Nicolaescu
2007-10-22 21:39           ` Glenn Morris
2007-10-23  1:01         ` Miles Bader
2007-10-23 10:39           ` Richard Stallman
2007-10-23 10:39         ` Richard Stallman [this message]
2007-10-27 10:46           ` Risky variables in Gnus (was: Warning: `mapcar' called for effect; use `mapc' or `dolist') Reiner Steib
2007-10-27 23:41             ` Richard Stallman
2007-10-28  0:02               ` Risky variables in Gnus Reiner Steib
2007-11-01 20:51                 ` Reiner Steib
2007-10-27 10:46           ` Rewriting gnus-group-highlight-line (was: Warning: `mapcar' called for effect; use `mapc' or `dolist') Reiner Steib
2007-10-27 23:41             ` Richard Stallman
2007-10-28  0:05           ` Reiner Steib
2007-10-23 10:39         ` Warning: `mapcar' called for effect; use `mapc' or `dolist' Richard Stallman
2007-10-31  7:46         ` Richard Stallman
2007-10-31 20:30           ` Reiner Steib
2007-10-31 21:19           ` Glenn Morris
2007-11-01  2:35           ` Katsumi Yamaoka
2007-10-24 19:28   ` Reiner Steib
2007-10-24 22:18     ` Katsumi Yamaoka
2007-10-27 13:34       ` Purpose of Gnus CVS branches (was: Warning: `mapcar' called for effect; use `mapc' or `dolist') Reiner Steib
2007-10-29  0:36         ` Purpose of Gnus CVS branches Katsumi Yamaoka
2007-10-28 16:58   ` Warning: `mapcar' called for effect; use `mapc' or `dolist' Dan Nicolaescu
2007-11-24 22:51     ` Removing obsolete `nnmail-spool-file' (was: Warning: `mapcar' called for effect; use `mapc' or `dolist') Reiner Steib

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1IkHAF-00040s-KJ@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=Reiner.Steib@gmx.de \
    --cc=dann@ics.uci.edu \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).