[sdl.web@gmail.com: window-system in face definition]

[sdl.web@gmail.com: window-system in face definition]

[Richard Stallman]

Would someone please DTRT then ack?

------- Start of forwarded message -------
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed 
	version=3.1.0
From: Leo <sdl.web@gmail.com>
To: Richard Stallman <rms@gnu.org>
Subject: window-system in face definition
Date: Sat, 27 Oct 2007 15:45:24 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

Dear Richard,

I intend to report a bug about Gnus which I have reported to Gnus
mailing list but apparently no one has paid attention.

Now that multi-tty has been merged into Emacs, window-system has become
a frame-local variable and is not sufficient to tell which single device
Emacs displays on or rather we should assume window-system is t in this
case. So the following code need to be changed (simplified)
accordingly. There might be other occurrences of such structure.

- ---- line 1119 of gnus-art.el ----

(defcustom gnus-treat-emphasize
  (and (or window-system
	   (featurep 'xemacs))
       50000)
  "Emphasize text.
Valid values are nil, t, `head', `first', `last', an integer or a
predicate.  See Info node `(gnus)Customizing Articles'."
  :group 'gnus-article-treat
  :link '(custom-manual "(gnus)Customizing Articles")
  :type gnus-article-treat-custom)

- ---------------------------------

Should be simplified to:

(defcustom gnus-treat-emphasize 5000
           ...)

HTH,
- -- 
.:  Leo  :.  [ sdl.web AT gmail.com ]  .:  [ GPG Key: 9283AA3F ]  :.

       Use the most powerful email client -- http://gnus.org/
------- End of forwarded message -------

Re: [sdl.web@gmail.com: window-system in face definition]

[Reiner Steib]

On Sun, Oct 28 2007, Richard Stallman wrote:

> Would someone please DTRT then ack?

Fixed in Gnus CVS.

> ------- Start of forwarded message -------
> From: Leo <sdl.web@gmail.com>
> To: Richard Stallman <rms@gnu.org>
> Subject: window-system in face definition
[...]
> Now that multi-tty has been merged into Emacs, window-system has become
> a frame-local variable and is not sufficient to tell which single device
> Emacs displays on or rather we should assume window-system is t in this
> case. So the following code need to be changed (simplified)
> accordingly. There might be other occurrences of such structure.

For this specific variable it doesn't matter, but is `window-system'
no longer the right way to test if the current display is on a
window system?

,----[ <f1> v window-system RET ]
| window-system is a variable defined in `C source code'.
| Its value is x
| 
| Documentation:
| Name of window system through which the selected frame is displayed.
| The value is a symbol--for instance, `x' for X windows.
| The value is nil if the selected frame is on a text-only-terminal.
`----

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: [sdl.web@gmail.com: window-system in face definition]

[Richard Stallman]

    For this specific variable it doesn't matter, but is `window-system'
    no longer the right way to test if the current display is on a
    window system?

I think it IS the right way, since the value of `window-system' will
vary according to each display.  But I am not 100% certain.