Gnus development mailing list
 help / color / mirror / Atom feed
From: Richard Stallman <rms@gnu.org>
To: Reiner Steib <Reiner.Steib@gmx.de>
Cc: tzz@lifelogs.com, ding@gnus.org, emacs-devel@gnu.org
Subject: Re: rfc2047.el dependencies on mm-util.el (was: Sending attachments)
Date: Sun, 19 Jul 2009 00:36:49 -0400	[thread overview]
Message-ID: <E1MSO8n-0002px-OE@fencepost.gnu.org> (raw)
In-Reply-To: <87eisdol9i.fsf_-_@marauder.physik.uni-ulm.de> (message from Reiner Steib on Sat, 18 Jul 2009 21:15:37 +0200)

    > rfc2047.el depends on some substantial code in mm-util.el:
    > mm-charset-to-coding-system and mm-find-mime-charset-region.  I cannot
    > understand that code, and I am not sure what it is trying to do.  I
    > understand the doc strings, but they explain only in vague terms.

    Please elaborate what is not clear...

If only a piece of it were unclear, that would be a reasonable question.
However, the problem is that I can't even begin to understand most
of those functions.  The necessary info is not present.

    MIME charsets are not the same as (Emacs) coding systems.  This
    function does the mapping and also handles overrides (many MUAs
    specify wrong charsets), invalid charsets, etc.

That is just the beginning of the necessary explanation for
understanding what this code does.  To state the purpose in general
terms like this is not enough.

To make the code clear means explaining the specifics of what it does.
Each group of a few lines needs comments to explain why those lines
are there.  Lots of background information needs to be provided.

    rfc2047.el implements (one of) the MIME standards.  mm-utils.el
    contains utility functions for MIME.  I.e. they are closely related.

Only part of mm-utils.el is closely related to rfc2047.el.  That part
is what I am talking about here.  It consists of the two functions
mm-find-mime-charset-region and mm-charset-to-coding-system, and their
subroutines and data.

    I'm not sure it is worth to separate out parts of it.

I don't think you and I are talking about the same "it".  The things
you think I want to separate, actually I want to keep together.

I am going to move rfc20457.el outside Gnus to make it a regular part
of Emacs.

What I want to do is keep the two functions
mm-find-mime-charset-region and mm-charset-to-coding-system (and their
subroutines and data) together with rfc2047.el, making them too a
regular part of Emacs.  This requires separating them from the rest of
mm-utils.el which will remain inside Gnus.  It also requires making
them clean and understandable.

I am asking Gnus developers to help me by do this by splitting mm-utils
and cleaning up this part.

If I have to do this on my own, then since I can't understand all the
code of these functions, I will have to delete parts of the code until
I can understand what remains.  Some features will be lost, but at
least it will be clear and maintainable.  Whatever features I had to
discard could be re-added later if someone can write them cleanly.

However, if you help, maybe we can achieve a better outcome in which
we get clean code that implements all the existing features of
mm-charset-to-coding-system and mm-find-mime-charset-region, and thus
have no inconvenience for anyone.






  reply	other threads:[~2009-07-19  4:36 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1MM5lq-0003BA-MV@fencepost.gnu.org>
     [not found] ` <87vdmcnfkc.fsf@catnip.gol.com>
     [not found]   ` <E1MMRqU-0001dM-E2@fencepost.gnu.org>
     [not found]     ` <buows6qij9t.fsf@dhlpc061.dev.necel.com>
     [not found]       ` <87bpo2i52l.fsf@iki.fi>
     [not found]         ` <buo7hyqi2b6.fsf@dhlpc061.dev.necel.com>
     [not found]           ` <jwv4otqn70c.fsf-monnier+emacs@gnu.org>
2009-07-06  6:45             ` message-mode / mail-mode Reiner Steib
2009-07-11 10:04               ` Stefan Monnier
     [not found] ` <87k52rzyn1.fsf@benthic.rattlesnake.com>
     [not found]   ` <873a9fw6dt.fsf@catnip.gol.com>
     [not found]     ` <87y6r7yp1y.fsf@stupidchicken.com>
     [not found]       ` <E1MMjdS-0004fU-SB@fencepost.gnu.org>
     [not found]         ` <0922916E-B9DD-41C4-8A3D-8550CDD56B62@mit.edu>
     [not found]           ` <83r5ww1m3k.fsf@gnu.org>
2009-07-05  2:39             ` Sending attachments Miles Bader
2009-07-05  3:18               ` Eli Zaretskii
2009-07-05  3:44                 ` Miles Bader
2009-07-05 18:16                   ` Eli Zaretskii
2009-07-05 20:44                     ` Miles Bader
2009-07-06  3:15                       ` Eli Zaretskii
2009-07-06  3:50                         ` Miles Bader
2009-07-06  4:54                           ` Miles Bader
2009-07-06 20:06                             ` Eli Zaretskii
2009-07-06 22:35                               ` Miles Bader
2009-07-07  0:59                                 ` Kenichi Handa
2009-07-07  9:43                                   ` Alfred M. Szmidt
2009-07-08  0:16                                   ` Richard Stallman
2009-07-11 15:45                                     ` Stefan Monnier
2009-07-06  6:37                           ` Alfred M. Szmidt
2009-07-06  7:47                             ` Miles Bader
2009-07-06 20:08                               ` Eli Zaretskii
2009-07-06 14:13                             ` Chong Yidong
2009-07-06 20:15                               ` Eli Zaretskii
2009-07-07  5:57                             ` Giorgos Keramidas
2009-07-06 15:05                       ` Richard Stallman
2009-07-11 19:08                         ` Stefan Monnier
2009-07-11 19:41                           ` Alfred M. Szmidt
2009-07-12  3:05                             ` Leo
2009-07-12  3:10                               ` Lennart Borgman
2009-07-13 12:11                             ` Stefan Monnier
2009-07-15  9:35                               ` Alfred M. Szmidt
2009-07-15 11:44                                 ` Richard Riley
2009-07-15 14:22                                 ` Stefan Monnier
2009-07-05 22:56                     ` Chong Yidong
2009-07-06 20:10                       ` Eli Zaretskii
2009-07-05  8:01               ` Andreas Schwab
2009-07-05  8:30                 ` Miles Bader
2009-07-06 15:05               ` Richard Stallman
     [not found]       ` <E1MMj74-0003cD-P4@fencepost.gnu.org>
     [not found]         ` <877hyp3by2.fsf@stupidchicken.com>
     [not found]           ` <E1MMrcO-0000SJ-K8@fencepost.gnu.org>
2009-07-15 21:51             ` Reducing Gnus dependencies in message.el (was: Sending attachments) Reiner Steib
     [not found] ` <E1MM5xL-0003WW-TZ@fencepost.gnu.org>
     [not found]   ` <E1MNFFR-0006gw-Dn@fencepost.gnu.org>
     [not found]     ` <jwvskhalrz5.fsf-monnier+emacs@gnu.org>
     [not found]       ` <E1MNpjn-0005Ab-1m@fencepost.gnu.org>
     [not found]         ` <jwvzlbbdybf.fsf-monnier+emacs@gnu.org>
     [not found]           ` <E1MPw2H-0006YD-7X@fencepost.gnu.org>
     [not found]             ` <jwvljmsbx5i.fsf-monnier+emacs@gnu.org>
     [not found]               ` <E1MQfUg-0005pF-Gr@fencepost.gnu.org>
     [not found]                 ` <87eisjjrsc.fsf@uwakimon.sk.tsukuba.ac.jp>
     [not found]                   ` <E1MRFUw-0001fh-MZ@fencepost.gnu.org>
     [not found]                     ` <87iqhsr8jm.fsf@lifelogs.com>
     [not found]                       ` <E1MRnWA-0004Yi-Cu@fencepost.gnu.org>
     [not found]                         ` <87my73kwxc.fsf@lifelogs.com>
     [not found]                           ` <E1MSDRN-0008TW-MF@fencepost.gnu.org>
2009-07-18 19:15                             ` rfc2047.el dependencies on mm-util.el " Reiner Steib
2009-07-19  4:36                               ` Richard Stallman [this message]
2009-07-19  5:30                                 ` rfc2047.el dependencies on mm-util.el Stefan Monnier
2009-07-19 23:21                                   ` Richard Stallman
2009-07-20 18:21                                     ` Stefan Monnier
2009-07-20 18:26                                       ` Bastien
2009-07-20 18:45                                         ` Chong Yidong
2009-07-21 14:41                                           ` Richard Stallman
2009-07-19 18:10                                 ` rfc2047.el dependencies on mm-util.el (was: Sending attachments) Eli Zaretskii
2009-07-19 23:22                                   ` Richard Stallman
2009-07-22 21:57                                   ` Kevin Ryde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1MSO8n-0002px-OE@fencepost.gnu.org \
    --to=rms@gnu.org \
    --cc=Reiner.Steib@gmx.de \
    --cc=ding@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=tzz@lifelogs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).