From: Hallvard B Furuseth <h.b.furuseth@usit.uio.no>
Subject: Re: Why can't `gnus-draft-setup' be bytecompiled?
Date: 14 Mar 1998 03:29:42 +0100 [thread overview]
Message-ID: <HBF.980314qxn9@bombur2.uio.no> (raw)
In-Reply-To: SL Baur's message of "09 Mar 1998 15:01:57 -0800"
SL Baur <steve@xemacs.org> writes:
> `gnus-draft-setup' is wrapped in a progn and has the annotation:
>
> ;;;!!!If this is byte-compiled, it fails miserably.
> ;;;!!!I have no idea why.
It *is* bytecompiled in emacs19. To leave it uncompiled, gnus-draft.el
would need
(dont-compile (defun gnus-draft-setup ...))
or, if you prefer,
(eval '(defun gnus-draft-setup ...))
It was the emacs18 compiler which only compiled top-level defuns.
Looking at this, I noticed a bug in gnus-setup-message:
(defmacro gnus-setup-message (config &rest forms)
...
`(let (...)
...
(set (make-local-variable 'gnus-message-group-art)
(cons ,gnus-newsgroup-name ,article))
^^^^^^^^^^^^^^^^^^^^
This expands to the value which gnus-newsgroup-name has *at compile
time*. That's normally nil, unless you byte-compile inside emacs.
Normally you should only use `,' in front of the macro arguments (or
values computed from the macro arguments). There are several other
occurrences of ",gnus-*" in gnus-msg.el. And other places, as seen with
egrep ',@* *(gnus|nn[a-z0-9]*)-' *.el
--
Hallvard
next prev parent reply other threads:[~1998-03-14 2:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-03-09 23:01 SL Baur
1998-03-09 23:19 ` Hrvoje Niksic
1998-03-13 21:39 ` Lars Magne Ingebrigtsen
1998-03-14 3:11 ` Hallvard B Furuseth
1998-03-14 3:23 ` Hrvoje Niksic
1998-03-14 4:09 ` Aaron M. Ucko
1998-03-19 12:30 ` Lars Magne Ingebrigtsen
1998-03-21 2:09 ` Aaron M. Ucko
1998-03-23 13:15 ` Lars Magne Ingebrigtsen
1998-03-14 2:29 ` Hallvard B Furuseth [this message]
1998-03-19 12:25 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HBF.980314qxn9@bombur2.uio.no \
--to=h.b.furuseth@usit.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).