two imap.el patches

two imap.el patches

[NAGY Andras]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

* http://www.gnus.org/list-archives/ding/200102/msg00282.html

The patch for imtest.c mentioned in this thread has been incorporated
into Cyrus-IMAP 2.0.14, so I suggest applying the relevant Gnus patch
as well.  (Or maybe a modified version, which provides an option to
choose between the pty and the pipe communication methods.)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: imap.el.patch-pty --]
[-- Type: text/x-patch, Size: 432 bytes --]

diff -u -r6.8 imap.el
--- imap.el	2001/06/03 10:10:50	6.8
+++ imap.el	2001/06/19 11:12:56
@@ -511,6 +511,7 @@
       (let* ((port (or port imap-default-port))
 	     (coding-system-for-read imap-coding-system-for-read)
 	     (coding-system-for-write imap-coding-system-for-write)
+	     (process-connection-type nil)
 	     (process (start-process 
 		       name buffer shell-file-name shell-command-switch
 		       (format-spec

[-- Attachment #3: Type: text/plain, Size: 113 bytes --]




* http://www.gnus.org/list-archives/ding/200012/msg00414.html

It seems to me this has not been applied yet.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: imap.el.patch-quiet --]
[-- Type: text/x-patch, Size: 809 bytes --]

diff -u -r6.3 imap.el
--- imap.el	2000/12/19 22:18:56	6.3
+++ imap.el	2000/12/30 16:06:56
@@ -188,10 +188,10 @@
   :group 'imap
   :type '(repeat string))
 
-(defcustom imap-ssl-program '("openssl s_client -ssl3 -connect %s:%p"
-			      "openssl s_client -ssl2 -connect %s:%p"
-			      "s_client -ssl3 -connect %s:%p"
-			      "s_client -ssl2 -connect %s:%p")
+(defcustom imap-ssl-program '("openssl s_client -quiet -ssl3 -connect %s:%p"
+			      "openssl s_client -quiet -ssl2 -connect %s:%p"
+			      "s_client -ssl3 -quiet -connect %s:%p"
+			      "s_client -ssl2 -quiet -connect %s:%p")
   "A string, or list of strings, containing commands for SSL connections.
 Within a string, %s is replaced with the server address and %p with
 port number on server.  The program should accept IMAP commands on

[-- Attachment #5: Type: text/plain, Size: 10 bytes --]




Andras

Re: two imap.el patches

[Simon Josefsson]

NAGY Andras <nagya@inf.elte.hu> writes:

> * http://www.gnus.org/list-archives/ding/200102/msg00282.html
> 
> The patch for imtest.c mentioned in this thread has been incorporated
> into Cyrus-IMAP 2.0.14, so I suggest applying the relevant Gnus patch
> as well.  (Or maybe a modified version, which provides an option to
> choose between the pty and the pipe communication methods.)

A customizable variable is nice, but I'm not sure nil is the best
default.

I mean, if the default is nil, it will not work at all if I have the
old imtest, and will work but with line length problems (that's all
right?) with the new imtest.  If the default is t, it will work but
have line length problems regardless of imtest version.

But perhaps it's better to have something that works completely when
using the latest software, and forcing users with old software to flip
a variable -- instead of forcing people with new software to flip the
variable.  Ok, I convinced myself.  Committed.

> * http://www.gnus.org/list-archives/ding/200012/msg00414.html
> 
> It seems to me this has not been applied yet.

Oops, I had completely missed this one.  Thanks, committed.

Re: two imap.el patches

[NAGY Andras]

On Tue, 19 Jun 2001, at 21:10, Simon Josefsson <jas@extundo.com> wrote:

> I mean, if the default is nil, it will not work at all if I have the
> old imtest, and will work but with line length problems (that's all
                                    ^out, you mean?
> right?) with the new imtest.  If the default is t, it will work but
> have line length problems regardless of imtest version.

Hm, I not sure about these line length problems... the major reason I
was looking for a solution not using a pty was the insecure pty
allocation method on some systems (notably AIX 4.3, which I am using
:).  I don't know if using a pty might introduce line length problems.

To summarize:
    
imtest version / p-c-t       nil                              t
<2.0.14                      does not work not at all         insecure
2.0.14+                      fine and secure                  insecure




Andras

Re: two imap.el patches

[Simon Josefsson]

On 20 Jun 2001, NAGY Andras wrote:

> On Tue, 19 Jun 2001, at 21:10, Simon Josefsson <jas@extundo.com> wrote:
>
> > I mean, if the default is nil, it will not work at all if I have the
> > old imtest, and will work but with line length problems (that's all
>                                     ^out, you mean?

Right. Oops.

> > right?) with the new imtest.  If the default is t, it will work but
> > have line length problems regardless of imtest version.
>
> Hm, I not sure about these line length problems... the major reason I
> was looking for a solution not using a pty was the insecure pty
> allocation method on some systems (notably AIX 4.3, which I am using
> :).  I don't know if using a pty might introduce line length problems.

Aha.  Using a pty makes us hurt from OS buffers on line length limits,
and some OSs (Irix come to mind) have 256 character line length buffers.
So using a pipe probably (but I'm not sure) means we don't have that
problem anymore, and that's a good thing.  If it improves security as
well, great.

> imtest version / p-c-t       nil                              t
> <2.0.14                      does not work not at all         insecure
> 2.0.14+                      fine and secure                  insecure

Right.  So it's a tradeoff between providing almost working solutions for
as many people as possible, or to provide a completely working and secure
solution for fewer. But then, people using GSSAPI or Krb4 is probably not
completely clueless and should be able to figure these things out, so nil
is a good default here. I added some information to gnus.texi about this.