From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/43653 Path: quimby.gnus.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.gnus.general Subject: Re: [patch] hierarchical lists in message.el Date: Tue, 26 Feb 2002 06:40:19 -0500 Organization: =?koi8-r?q?=F4=C5=CF=C4=CF=D2=20=FA=CC=C1=D4=C1=CE=CF=D7?= @ Cienfuegos Message-ID: References: NNTP-Posting-Host: quimby2.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: quimby2.netfonds.no 1014724155 1238 195.204.10.66 (26 Feb 2002 11:49:15 GMT) X-Complaints-To: usenet@quimby2.netfonds.no NNTP-Posting-Date: 26 Feb 2002 11:49:15 GMT Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by quimby2.netfonds.no with esmtp (Exim 3.12 #1 (Debian)) id 16fg6c-0000Jn-00; Tue, 26 Feb 2002 12:49:14 +0100 Original-Received: from sina.hpc.uh.edu ([129.7.128.10] ident=lists) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 16ffyt-0000aN-00; Tue, 26 Feb 2002 05:41:15 -0600 Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Tue, 26 Feb 2002 05:41:15 -0600 (CST) Original-Received: from sclp3.sclp.com (qmailr@sclp3.sclp.com [209.196.61.66]) by sina.hpc.uh.edu (8.9.3/8.9.3) with SMTP id FAA19555 for ; Tue, 26 Feb 2002 05:41:00 -0600 (CST) Original-Received: (qmail 29850 invoked by alias); 26 Feb 2002 11:40:53 -0000 Original-Received: (qmail 29845 invoked from network); 26 Feb 2002 11:40:53 -0000 Original-Received: from liilmtlssm01.mailtask.com (208.203.59.25) by gnus.org with SMTP; 26 Feb 2002 11:40:53 -0000 Original-Received: from onyx.nimbus.northernlight.com ([10.128.22.65]) by LIILMTLSSM01.mailtask.com with Microsoft SMTPSVC(5.0.2195.3779); Tue, 26 Feb 2002 05:40:25 -0600 Original-To: ding@gnus.org X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Followup-To: ding@gnus.org In-Reply-To: (prj@po.cwru.edu's message of "Mon, 25 Feb 2002 18:22:17 -0500") Original-Lines: 46 User-Agent: Gnus/5.090006 (Oort Gnus v0.06) Emacs/21.1 (i386-redhat-linux-gnu) X-OriginalArrivalTime: 26 Feb 2002 11:40:25.0975 (UTC) FILETIME=[61F56070:01C1BEBA] Precedence: list X-Majordomo: 1.94.jlt7 Xref: quimby.gnus.org gmane.emacs.gnus.general:43653 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:43653 prj@po.cwru.edu (Paul Jarc) writes: > Ted Zlatanov wrote: >> It being the first patch I've done for Gnus, I don't know if it >> should go to the list or to someone in particular. > > This is the place for it. Have you signed the copyright paperwork? No, can someone get in touch with me? >> +(defcustom message-hierarchical-lists nil >> + "A list of hierarchical mailing list definitions. >> + >> +Inside each entry, the first address is the top list, everything after >> +it are secondary addresses contained in the list. The secondaries >> +will be removed from the list of recipients when mail is prepared for >> +delivery." >> + :group 'message-headers) > > We should also say that secondaries of secondaries, and so on, will be > removed, and it probably would be good to spell out more explicitly > that this is a way for the user to express to Gnus that messages sent > to the first address are automatically delivered to the others, which > is *why* Gnus will remove the subordinates, so no one is left > wondering when this thing would be useful. Maybe that would be better > off in the manual than in the docstring; the manual could also give an > example. I also don't quite like the word "secondaries" (maybe > "sublists"?) but that's just a nit. Detailed instructions should definitely go in the manual. "sublists" does sound better than "secondaries." >> + ;; remove hierarchical lists that are contained within each other, >> + ;; if message-hierarchical-lists is defined >> + (when message-hierarchical-lists > > It happens that this "when" test is not strictly necessary; the code > will have nothing to remove if m-h-l is empty. But maybe this is > still a worthwhile optimization for the common case. Yes, I think it improves the code for someone glancing through it - they don't have to figure out the logic to see that it will do nothing without m-h-l (code comments being the first thing no one reads :) Thanks Ted