Gnus development mailing list
 help / color / mirror / Atom feed
From: Andreas Seltenreich <andreas+ding@gate450.dyndns.org>
Cc: Ralf Wachinger <rwnewsmampfer@geekmail.de>
Subject: gnus-article-only-boring-p vs. intangible text
Date: Tue, 14 Mar 2006 22:54:40 +0100	[thread overview]
Message-ID: <andreasirqgpu8v.fsf@gate450.dyndns.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

Hi,

gnus-article-only-boring-p refuses to terminate when it runs into a
word inside intangible text. This could happen, e.g., when
gnus-article-skip-boring and gnus-treat-hide-signature are enabled at
the same time, as reported in de.comm.software.gnus:
<news:19de1dbd08fdc8c65fb81efab9f69c0f@wachinger.fqdn.th-h.de>

The attached patch seems to fix it for trunk and v5-10.

Thanks,
andreas

2006-03-14  Andreas Seltenreich  <uwi7@rz.uni-karlsruhe.de>

	* gnus-art.el (gnus-article-only-boring-p): Avoid endless looping
	when running into intangible text.  Reported by Ralf Wachinger
	<rwnewsmampfer@geekmail.de>.


[-- Attachment #2: gnus-art.diff --]
[-- Type: text/plain, Size: 1386 bytes --]

Index: gnus-art.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-art.el,v
retrieving revision 7.154
diff -c -r7.154 gnus-art.el
*** gnus-art.el	13 Mar 2006 09:32:28 -0000	7.154
--- gnus-art.el	14 Mar 2006 21:12:08 -0000
***************
*** 5551,5564 ****
  	     (boundp 'gnus-article-boring-faces)
  	     (symbol-value 'gnus-article-boring-faces))
      (save-excursion
!       (catch 'only-boring
! 	(while (re-search-forward "\\b\\w\\w" nil t)
! 	  (forward-char -1)
! 	  (when (not (gnus-intersection
! 		      (gnus-faces-at (point))
! 		      (symbol-value 'gnus-article-boring-faces)))
! 	    (throw 'only-boring nil)))
! 	(throw 'only-boring t)))))
  
  (defun gnus-article-refer-article ()
    "Read article specified by message-id around point."
--- 5551,5565 ----
  	     (boundp 'gnus-article-boring-faces)
  	     (symbol-value 'gnus-article-boring-faces))
      (save-excursion
!       (let ((inhibit-point-motion-hooks t))
! 	(catch 'only-boring
! 	  (while (re-search-forward "\\b\\w\\w" nil t)
! 	    (forward-char -1)
! 	    (when (not (gnus-intersection
! 			(gnus-faces-at (point))
! 			(symbol-value 'gnus-article-boring-faces)))
! 	      (throw 'only-boring nil)))
! 	  (throw 'only-boring t))))))
  
  (defun gnus-article-refer-article ()
    "Read article specified by message-id around point."

             reply	other threads:[~2006-03-14 21:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-14 21:54 Andreas Seltenreich [this message]
2006-03-15 13:27 ` Reiner Steib

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=andreasirqgpu8v.fsf@gate450.dyndns.org \
    --to=andreas+ding@gate450.dyndns.org \
    --cc=rwnewsmampfer@geekmail.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).