gnus-article-only-boring-p vs. intangible text

gnus-article-only-boring-p vs. intangible text

[Andreas Seltenreich]

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

Hi,

gnus-article-only-boring-p refuses to terminate when it runs into a
word inside intangible text. This could happen, e.g., when
gnus-article-skip-boring and gnus-treat-hide-signature are enabled at
the same time, as reported in de.comm.software.gnus:
<news:19de1dbd08fdc8c65fb81efab9f69c0f@wachinger.fqdn.th-h.de>

The attached patch seems to fix it for trunk and v5-10.

Thanks,
andreas

2006-03-14  Andreas Seltenreich  <uwi7@rz.uni-karlsruhe.de>

	* gnus-art.el (gnus-article-only-boring-p): Avoid endless looping
	when running into intangible text.  Reported by Ralf Wachinger
	<rwnewsmampfer@geekmail.de>.


[-- Attachment #2: gnus-art.diff --]
[-- Type: text/plain, Size: 1386 bytes --]

Index: gnus-art.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-art.el,v
retrieving revision 7.154
diff -c -r7.154 gnus-art.el
*** gnus-art.el	13 Mar 2006 09:32:28 -0000	7.154
--- gnus-art.el	14 Mar 2006 21:12:08 -0000
***************
*** 5551,5564 ****
  	     (boundp 'gnus-article-boring-faces)
  	     (symbol-value 'gnus-article-boring-faces))
      (save-excursion
!       (catch 'only-boring
! 	(while (re-search-forward "\\b\\w\\w" nil t)
! 	  (forward-char -1)
! 	  (when (not (gnus-intersection
! 		      (gnus-faces-at (point))
! 		      (symbol-value 'gnus-article-boring-faces)))
! 	    (throw 'only-boring nil)))
! 	(throw 'only-boring t)))))
  
  (defun gnus-article-refer-article ()
    "Read article specified by message-id around point."
--- 5551,5565 ----
  	     (boundp 'gnus-article-boring-faces)
  	     (symbol-value 'gnus-article-boring-faces))
      (save-excursion
!       (let ((inhibit-point-motion-hooks t))
! 	(catch 'only-boring
! 	  (while (re-search-forward "\\b\\w\\w" nil t)
! 	    (forward-char -1)
! 	    (when (not (gnus-intersection
! 			(gnus-faces-at (point))
! 			(symbol-value 'gnus-article-boring-faces)))
! 	      (throw 'only-boring nil)))
! 	  (throw 'only-boring t))))))
  
  (defun gnus-article-refer-article ()
    "Read article specified by message-id around point."

Re: gnus-article-only-boring-p vs. intangible text

[Reiner Steib]

On Tue, Mar 14 2006, Andreas Seltenreich wrote:

> gnus-article-only-boring-p refuses to terminate when it runs into a
> word inside intangible text. This could happen, e.g., when
> gnus-article-skip-boring and gnus-treat-hide-signature are enabled at
> the same time, as reported in de.comm.software.gnus:
> <news:19de1dbd08fdc8c65fb81efab9f69c0f@wachinger.fqdn.th-h.de>
>
> The attached patch seems to fix it for trunk and v5-10.

Thanks for your patch.  Installed in trunk and v5-10.

I've modified the ChangeLog a bit:

,----
| 2006-03-15  Andreas Seltenreich  <uwi7@rz.uni-karlsruhe.de>
| 
| 	* gnus-art.el (gnus-article-only-boring-p): Bind
| 	inhibit-point-motion-hooks to avoid infinite loop when entering
| 	intangible text.  Reported by Ralf Wachinger
| 	<rwnewsmampfer@geekmail.de>.
`----

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/