Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: David Engster <dengste@eml.cc>
Cc: Steinar Bang <sb@dod.no>, ding@gnus.org
Subject: Re: nndrafts folder doesn't display the Drafts menu
Date: Tue, 06 Jan 2009 15:46:00 +0900	[thread overview]
Message-ID: <b4m1vvh7x07.fsf@jpl.org> (raw)
In-Reply-To: <b4mhc4d7xsp.fsf@jpl.org>

[-- Attachment #1: Type: text/plain, Size: 149 bytes --]

>>>>> Katsumi Yamaoka wrote:
> David, do you have an idea to fix this?

How about this one (evaluate parameter's operands but don't set
variables)?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1307 bytes --]

--- gnus-sum.el~	2008-12-25 02:41:43 +0000
+++ gnus-sum.el	2009-01-06 06:42:33 +0000
@@ -3831,18 +3831,18 @@
       (and (consp elem)			; Has to be a cons.
 	   (consp (cdr elem))		; The cdr has to be a list.
 	   (symbolp (car elem))		; Has to be a symbol in there.
-
-	   ;; Variables like `gnus-show-threads' that are globally bound,
-	   ;; if used as group parameters, need to get to be buffer-local,
-	   ;; whereas just parameters like `gcc-self', `timestamp', etc.
-	   ;; should not be bound as variables.
-	   (boundp (car elem))		; Has to be already bound
-
 	   (not (memq (car elem) vars))
-	   (ignore-errors		; So we set it.
+	   (ignore-errors
 	     (push (car elem) vars)
-	     (make-local-variable (car elem))
-	     (set (car elem) (eval (nth 1 elem))))))))
+	     ;; Variables like `gnus-show-threads' that are globally
+	     ;; bound, if used as group parameters, need to get to be
+	     ;; buffer-local, whereas just parameters like `gcc-self',
+	     ;; `timestamp', etc. should not be bound as variables.
+	     (if (boundp (car elem))
+		 (progn
+		   (make-local-variable (car elem))
+		   (set (car elem) (eval (nth 1 elem))))
+	       (eval (nth 1 elem))))))))
 
 (defun gnus-summary-read-group (group &optional show-all no-article
 				      kill-buffer no-display backward

  reply	other threads:[~2009-01-06  6:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-05 11:58 Steinar Bang
2009-01-05 12:36 ` Steinar Bang
2009-01-05 19:23   ` Steinar Bang
2009-01-05 20:28     ` Dave Goldberg
2009-01-05 20:51       ` Steinar Bang
2009-01-05 22:54         ` Dave Goldberg
2009-01-06  6:28           ` Katsumi Yamaoka
2009-01-06  6:46             ` Katsumi Yamaoka [this message]
2009-01-06 12:56               ` David Engster
2009-01-06 22:11                 ` Katsumi Yamaoka
2009-01-06  6:49             ` Steinar Bang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4m1vvh7x07.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=dengste@eml.cc \
    --cc=ding@gnus.org \
    --cc=sb@dod.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).