Re: gnus-article-read-summary-keys: can't handle hidden summary buffer?

[Katsumi Yamaoka <yamaoka@jpl.org>]

>>>>> Miles Bader wrote:
> If I select the article window, and hide the summary buffer (something I
> often like to do while reading long threads), then many inter-article
> movement commands give an error like:

>    gnus-article-read-summary-keys: Wrong type argument: window-live-p, #<window 44>

> The commands still seem to pretty much do the right thing (for instance,
> "n" still moves to the next message), but the constant error messages
> are annoying (and presumably there are some minor functional differences
> as well).

> This used to work properly, with no error messages.  I'm not really sure
> when error messages started showing up, but sometime in the medium-past
> (at least the last year or so I think?).

> The stack backtrace is:

>    Debugger entered--Lisp error: (wrong-type-argument window-live-p #<window 52>)
>      window-buffer(#<window 52>)
>      (set-buffer (window-buffer win))
                                  ^^^
[...]
>      gnus-article-read-summary-keys(nil)
>      call-interactively(gnus-article-read-summary-keys nil nil)

> Thanks,

I couldn't reproduce it but I can imagine it is possible to happen.
Even in the case where the summary buffer is hidden, the summary
window appears a moment (it is necessary for running a summary
command) and the window `win' is set to it at that time.  After
the summary window is hidden again, in my case `win' points to
the window in which there is the article buffer (i.e. `win' is
still alive but the buffer which the window visits is changed
from the summary buffer).  However, it is possible that `win'
points to non-existent window for some reason.  It might be due
to user's hook function, a customized window configuration, or
other.  So I think it should be checked whether it exists.
Could you test this patch?

--- gnus-art.el~	2008-08-11 22:24:20 +0000
+++ gnus-art.el	2008-09-29 11:06:22 +0000
@@ -6373,6 +6373,7 @@
 				      (point))))
 		(when (and (not not-restore-window)
 			   new-sum-point
+			   (window-live-p win)
 			   (with-current-buffer (window-buffer win)
 			     (eq major-mode 'gnus-summary-mode)))
 		  (set-window-point win new-sum-point)

(Anyway there still be some codes of which the uses are unknown
 in `gnus-article-read-summary-keys', though.)

Regards,