Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: ding@gnus.org
Subject: Re: nntp-send-authinfo doesn't look at nntp-port-number
Date: Fri, 24 Feb 2012 08:11:14 +0900	[thread overview]
Message-ID: <b4m4nuhqh65.fsf@jpl.org> (raw)
In-Reply-To: <871uplww7d.fsf@Gmail.com>

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

XeCycle wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:
> [...]
>> Maybe the following patch will make it work.  Er, but I don't
>> know whether it's right to add "nntps" and "snews"...

>> --- nntp.el~	2012-02-15 09:22:23.734375000 +0000
>> +++ nntp.el	2012-02-23 11:02:16.234375000 +0000
>> @@ -1197,7 +1197,8 @@
[...]
>> -                                     :port '("119" "nntp"))))
>> +                                     :port '("119" "nntp"
>> +					     "563" "nntps" "snews"))))
[...]

> Thanks for this, but is there no way to check the defined port
> number?  That would be more robust.

Ok.  I've added the next one to No Gnus, Ma Gnus, and Emacs 24.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 690 bytes --]

--- nntp.el~	2012-02-15 09:22:23.734375000 +0000
+++ nntp.el	2012-02-23 23:06:23.984375000 +0000
@@ -1196,6 +1196,9 @@
          (auth-info
-          (nth 0 (auth-source-search :max 1
-                                     :host (list nntp-address
-                                                 (nnoo-current-server 'nntp))
-                                     :port '("119" "nntp"))))
+          (nth 0 (auth-source-search
+		  :max 1
+		  :host (list nntp-address
+			      (nnoo-current-server 'nntp))
+		  :port (or (cdr (assoc (format "%s" nntp-port-number)
+					'(("563" . ("563" "nntps" "snews")))))
+			    '("119" "nntp")))))
          (auth-user (plist-get auth-info :user))

  reply	other threads:[~2012-02-23 23:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-23  6:38 XeCycle
2012-02-23 11:05 ` Katsumi Yamaoka
2012-02-23 12:49   ` XeCycle
2012-02-23 23:11     ` Katsumi Yamaoka [this message]
2012-02-24 15:42       ` Ted Zlatanov
2012-02-25  0:41         ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4m4nuhqh65.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).