Re: closing all inactive server connections

[Katsumi Yamaoka <yamaoka@jpl.org>]

>>>>> Ted Zlatanov wrote:
> On Fri, 27 Jul 2007 13:06:14 -0400 Ted Zlatanov <tzz@lifelogs.com> wrote:

TZ> Here's a version of gnus-server-close-all-servers that works on all the
TZ> server in the buffer.  I preserved the old (buggy I think) behavior with
TZ> the `some' parameter.  Can I commit this change?  It works for me.

> I had to revise the function, apparently I need both lists.

> (defun gnus-server-close-all-servers ()
>   "Close all servers."
>   (interactive)
>   (let ((servers (append
>                   gnus-inserted-opened-servers
>                   gnus-server-alist)))
>   (dolist (server servers)
>     (gnus-server-close-server (car server)))))

> I tested this on several Gnus setups and it seems OK.

I can agree to this change if it is really helpful to you.  But
you still need to type `C-g' for almost servers when the VPN is
disconnected, don't you?  Even so, is it really helpful to you?
I don't have a problem like yours and don't know how to reproduce
it without VPN, so don't know how to solve it so far.

In addition, isn't it unnecessary to use `let'?  I mean:

(defun gnus-server-close-all-servers ()
  "Close all servers."
  (interactive)
  (dolist (server gnus-inserted-opened-servers)
    (gnus-server-close-server (car server)))
  (dolist (server gnus-server-alist)
    (gnus-server-close-server (car server))))

or

(defun gnus-server-close-all-servers ()
  "Close all servers."
  (interactive)
  (dolist (server (append gnus-inserted-opened-servers gnus-server-alist))
    (gnus-server-close-server (car server))))

TZ> Unfortunately there were tabs in the gnus-srvr.el file (aren't we
TZ> supposed to use untabify?) so the patch comes out too long.

I cannot understand what you want to do.  gnus-srvr.el in the CVS
trunk uses tabs for the indentations that require eight or more
characters width (except for only one line).  The reason the patch
is big should be that you, some program or other untabified them.
Do you think that it should be applied to all the Gnus sources?
I don't agree.  IMO, whoever changes the Gnus sources should use
the default value for the `indent-tabs-mode' variable.

> Any response on this?  Reiner?  The function gnus-server-close-server is
> definitely better that the old version, and I believe we shouldn't have
> tabs.  I'll commit the untabified version unless I hear from someone.