From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/64991 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: closing all inactive server connections Date: Mon, 30 Jul 2007 15:22:50 +0900 Organization: Emacsen advocacy group Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1185776731 15283 80.91.229.12 (30 Jul 2007 06:25:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 30 Jul 2007 06:25:31 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M13501@lists.math.uh.edu Mon Jul 30 08:25:25 2007 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1IFOh2-0000V1-MG for ding-account@gmane.org; Mon, 30 Jul 2007 08:25:25 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1IFOfo-0002mX-Rs; Mon, 30 Jul 2007 01:24:08 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1IFOfm-0002m8-Ne for ding@lists.math.uh.edu; Mon, 30 Jul 2007 01:24:06 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.67) (envelope-from ) id 1IFOfg-0001lL-Bc for ding@lists.math.uh.edu; Mon, 30 Jul 2007 01:24:06 -0500 Original-Received: from orlando.hostforweb.net ([216.246.45.90]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1IFOff-0006qs-00 for ; Mon, 30 Jul 2007 08:23:59 +0200 Original-Received: from [66.225.201.151] (port=46657 helo=mail.jpl.org) by orlando.hostforweb.net with esmtpa (Exim 4.63) (envelope-from ) id 1IFOez-0002uL-Bc for ding@gnus.org; Mon, 30 Jul 2007 01:23:18 -0500 X-Hashcash: 1:20:070730:ding@gnus.org::Xgf+CBOboaYJpC6A:000012gr X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1.50 (gnu/linux) Cancel-Lock: sha1:lvEbllMc3RuFP8aSclGWmiLKQzU= X-Antivirus-Scanner: Clean mail though you should still use an Antivirus X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -2.5 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:64991 Archived-At: >>>>> Ted Zlatanov wrote: > On Fri, 27 Jul 2007 13:06:14 -0400 Ted Zlatanov wrote: TZ> Here's a version of gnus-server-close-all-servers that works on all the TZ> server in the buffer. I preserved the old (buggy I think) behavior with TZ> the `some' parameter. Can I commit this change? It works for me. > I had to revise the function, apparently I need both lists. > (defun gnus-server-close-all-servers () > "Close all servers." > (interactive) > (let ((servers (append > gnus-inserted-opened-servers > gnus-server-alist))) > (dolist (server servers) > (gnus-server-close-server (car server))))) > I tested this on several Gnus setups and it seems OK. I can agree to this change if it is really helpful to you. But you still need to type `C-g' for almost servers when the VPN is disconnected, don't you? Even so, is it really helpful to you? I don't have a problem like yours and don't know how to reproduce it without VPN, so don't know how to solve it so far. In addition, isn't it unnecessary to use `let'? I mean: (defun gnus-server-close-all-servers () "Close all servers." (interactive) (dolist (server gnus-inserted-opened-servers) (gnus-server-close-server (car server))) (dolist (server gnus-server-alist) (gnus-server-close-server (car server)))) or (defun gnus-server-close-all-servers () "Close all servers." (interactive) (dolist (server (append gnus-inserted-opened-servers gnus-server-alist)) (gnus-server-close-server (car server)))) TZ> Unfortunately there were tabs in the gnus-srvr.el file (aren't we TZ> supposed to use untabify?) so the patch comes out too long. I cannot understand what you want to do. gnus-srvr.el in the CVS trunk uses tabs for the indentations that require eight or more characters width (except for only one line). The reason the patch is big should be that you, some program or other untabified them. Do you think that it should be applied to all the Gnus sources? I don't agree. IMO, whoever changes the Gnus sources should use the default value for the `indent-tabs-mode' variable. > Any response on this? Reiner? The function gnus-server-close-server is > definitely better that the old version, and I believe we shouldn't have > tabs. I'll commit the untabified version unless I hear from someone.