Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: ksinya@quartz.ocn.ne.jp, larsi@gnus.org
Subject: Re: Gnus doesn't update nntp marks files when unplugged
Date: Thu, 02 Feb 2006 18:33:07 +0900	[thread overview]
Message-ID: <b4m64nyaywc.fsf@jpl.org> (raw)
In-Reply-To: <ilulkwvz1pn.fsf@latte.josefsson.org>

[-- Attachment #1: Type: text/plain, Size: 1472 bytes --]

;; I added Lars to Cc:.

Does anyone know what is *exceedingly slow*?  I'm using only
nntp and nnml, moreover am always plugged, so it is hard to
imagine what kind of back end slows Gnus down by synchronizing
flags.

>> 2005-09-20  Lars Magne Ingebrigtsen  <larsi@gnus.org>

>> 	* gnus-agent.el (gnus-agent-synchronize-flags): Switch the
>> 	default to nil, to be able to use Gnus at all.  If the default
>> 	switches to something else, then the function should be fixed not
>> 	be exceedingly slow.

>> 2004-07-09  Simon Josefsson  <jas@extundo.com>

>> 	* gnus-agent.el (gnus-agent-synchronize-flags): Revert to ask.
>> 	Users will lose all flag changes made while unplugged with
>> 	e.g. nntp unless flag synchronization happens, thus `nil' is not a
>> 	good default.  See numerous reports on ding mailing list.

> Katsumi Yamaoka <yamaoka@jpl.org> writes:

>> IMHO, we should set gnus-agent-synchronize-flags to t by default
>> or synchronize at least nntp marks automatically when Gnus is
>> re-plugged even if it takes time.  I don't know how it is slow
>> so far, though.

>>>>> In <ilulkwvz1pn.fsf@latte.josefsson.org> Simon Josefsson wrote:

> I agree.  I have never found it that slow.  It is not disk or network
> bound.  I read pretty large nntp groups offline, and syncing the flags
> doesn't seem to take that long.

I don't feel updating nntp marks is slow either.  If only the
back end which doesn't make it slow is nntp, I can make the
following change:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 724 bytes --]

--- gnus-agent.el~	2006-01-25 07:33:34 +0000
+++ gnus-agent.el	2006-02-02 09:31:37 +0000
@@ -874,8 +874,10 @@
       (kill-buffer nil))))
 
 (defun gnus-agent-possibly-synchronize-flags-server (method)
-  "Synchronize flags for server according to `gnus-agent-synchronize-flags'."
-  (when (or (and gnus-agent-synchronize-flags
+  "Synchronize flags for server according to `gnus-agent-synchronize-flags'.
+Exceptionally, nntp marks are synchronized with flags unconditionally."
+  (when (or (memq (car method) '(nntp))
+	    (and gnus-agent-synchronize-flags
 		 (not (eq gnus-agent-synchronize-flags 'ask)))
 	    (and (eq gnus-agent-synchronize-flags 'ask)
 		 (gnus-y-or-n-p (format "Synchronize flags on server `%s'? "

  reply	other threads:[~2006-02-02  9:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-31 12:23 Katsumi Yamaoka
2006-02-01  4:51 ` Katsumi Yamaoka
2006-02-01 12:46   ` Simon Josefsson
2006-02-02  9:33     ` Katsumi Yamaoka [this message]
2006-04-12 10:39       ` Lars Magne Ingebrigtsen
2006-04-18  8:50         ` Simon Josefsson
2006-04-18 16:27           ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4m64nyaywc.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=ksinya@quartz.ocn.ne.jp \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).