* make-variable-buffer-local in sieve-manage.el
@ 2005-08-01 8:11 Katsumi Yamaoka
2005-08-02 9:47 ` Simon Josefsson
0 siblings, 1 reply; 3+ messages in thread
From: Katsumi Yamaoka @ 2005-08-01 8:11 UTC (permalink / raw)
Hi,
In sieve-manage.el, shouldn't `make-variable-buffer-local' used
in several places be replaced with `make-local-variable'? For
instance:
(defun sieve-manage-interactive-login (buffer loginfunc)
"Login to server in BUFFER.
LOGINFUNC is passed a username and a password, it should return t if
it where sucessful authenticating itself to the server, nil otherwise.
Returns t if login was successful, nil otherwise."
(with-current-buffer buffer
(make-variable-buffer-local 'sieve-manage-username)
(make-variable-buffer-local 'sieve-manage-password)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: make-variable-buffer-local in sieve-manage.el
2005-08-01 8:11 make-variable-buffer-local in sieve-manage.el Katsumi Yamaoka
@ 2005-08-02 9:47 ` Simon Josefsson
2005-08-02 10:14 ` Katsumi Yamaoka
0 siblings, 1 reply; 3+ messages in thread
From: Simon Josefsson @ 2005-08-02 9:47 UTC (permalink / raw)
Cc: ding
Katsumi Yamaoka <yamaoka@jpl.org> writes:
> Hi,
>
> In sieve-manage.el, shouldn't `make-variable-buffer-local' used
> in several places be replaced with `make-local-variable'? For
> instance:
Probably, yes. Please go ahead and make the change.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: make-variable-buffer-local in sieve-manage.el
2005-08-02 9:47 ` Simon Josefsson
@ 2005-08-02 10:14 ` Katsumi Yamaoka
0 siblings, 0 replies; 3+ messages in thread
From: Katsumi Yamaoka @ 2005-08-02 10:14 UTC (permalink / raw)
Cc: ding
> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>> In sieve-manage.el, shouldn't `make-variable-buffer-local' used
>> in several places be replaced with `make-local-variable'?
>>>>> In <iluoe8ghdra.fsf@latte.josefsson.org> Simon Josefsson wrote:
> Probably, yes. Please go ahead and make the change.
Thanks. I've done so in the v5-10 branch and the trunk.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-08-02 10:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-08-01 8:11 make-variable-buffer-local in sieve-manage.el Katsumi Yamaoka
2005-08-02 9:47 ` Simon Josefsson
2005-08-02 10:14 ` Katsumi Yamaoka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).