* Re: bug#4698: 23.1; C-l in gnus differs from other modes [not found] <m3vdim4tch.fsf@fleche.redhat.com> @ 2009-10-14 18:23 ` Reiner Steib 2009-10-16 7:46 ` Katsumi Yamaoka 0 siblings, 1 reply; 3+ messages in thread From: Reiner Steib @ 2009-10-14 18:23 UTC (permalink / raw) To: Tom Tromey; +Cc: 4698, ding On Sun, Oct 11 2009, Tom Tromey wrote: > Emacs changed the default C-l binding to recenter-top-bottom. > However, C-l in the gnus summary buffer is still gnus-recenter, > which just calls recenter. > I think it would be nice if gnus followed the user's setting here. Here's a mostly untested patch: --8<---------------cut here---------------start------------->8--- --- gnus-sum.el 9 Sep 2009 09:31:35 -0000 7.240 +++ gnus-sum.el 14 Oct 2009 18:19:46 -0000 @@ -6722,7 +6725,9 @@ (when (and gnus-auto-center-summary (not (eq gnus-auto-center-summary 'vertical))) (gnus-horizontal-recenter)) - (recenter n)) + (if (fboundp 'recenter-top-bottom) + (recenter-top-bottom n) + (recenter n))) (defun gnus-summary-recenter () "Center point in the summary window. --8<---------------cut here---------------end--------------->8--- Could you please test it for a while and report back? Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/ ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bug#4698: 23.1; C-l in gnus differs from other modes 2009-10-14 18:23 ` bug#4698: 23.1; C-l in gnus differs from other modes Reiner Steib @ 2009-10-16 7:46 ` Katsumi Yamaoka 2009-11-30 18:24 ` Reiner Steib 0 siblings, 1 reply; 3+ messages in thread From: Katsumi Yamaoka @ 2009-10-16 7:46 UTC (permalink / raw) To: Tom Tromey; +Cc: 4698, Gnus >>>>> Reiner Steib wrote: > On Sun, Oct 11 2009, Tom Tromey wrote: >> Emacs changed the default C-l binding to recenter-top-bottom. >> However, C-l in the gnus summary buffer is still gnus-recenter, >> which just calls recenter. >> I think it would be nice if gnus followed the user's setting here. > Here's a mostly untested patch: [...] > Could you please test it for a while and report back? Looks good. Thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: bug#4698: 23.1; C-l in gnus differs from other modes 2009-10-16 7:46 ` Katsumi Yamaoka @ 2009-11-30 18:24 ` Reiner Steib 0 siblings, 0 replies; 3+ messages in thread From: Reiner Steib @ 2009-11-30 18:24 UTC (permalink / raw) To: Tom Tromey, 4698, ding On Fri, Oct 16 2009, Katsumi Yamaoka wrote: >>>>>> Reiner Steib wrote: >> On Sun, Oct 11 2009, Tom Tromey wrote: > >>> Emacs changed the default C-l binding to recenter-top-bottom. >>> However, C-l in the gnus summary buffer is still gnus-recenter, >>> which just calls recenter. >>> I think it would be nice if gnus followed the user's setting here. > >> Here's a mostly untested patch: > > [...] > >> Could you please test it for a while and report back? > > Looks good. Thanks. Closing this bug as it was fixed by this change: 2009-11-29 Juri Linkov <juri@jurta.org> * gnus-sum.el (gnus-recenter): Use `recenter-top-bottom' when it is fboundp in GNU Emacs 23.1. Put `isearch-scroll' property on `gnus-recenter'. (Bug#4698, Bug#4981) Bye, Reiner ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-30 18:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <m3vdim4tch.fsf@fleche.redhat.com>
2009-10-14 18:23 ` bug#4698: 23.1; C-l in gnus differs from other modes Reiner Steib
2009-10-16 7:46 ` Katsumi Yamaoka
2009-11-30 18:24 ` Reiner Steib
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).