From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/67979 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general,gmane.emacs.jabber.general Subject: Re: gnus shouldn't be making general-purpose variables buffer-local Followup-To: gmane.emacs.gnus.general Date: Wed, 24 Dec 2008 11:32:12 +0900 Organization: Emacsen advocacy group Message-ID: References: <9aa0cfde0812112242o38d885a1h12d9e4ac490021@mail.gmail.com> <863agokpas.fsf@lifelogs.com> <87vdtj41ux.fsf@engster.org> <87bpv4ca5g.fsf@marauder.physik.uni-ulm.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1230085967 12827 80.91.229.12 (24 Dec 2008 02:32:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 24 Dec 2008 02:32:47 +0000 (UTC) Cc: emacs-jabber-general@lists.sourceforge.net, Ami Fischman , emacs-devel@gnu.org To: ding@gnus.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 24 03:33:52 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LFJZG-0002PU-NU for ged-emacs-devel@m.gmane.org; Wed, 24 Dec 2008 03:33:50 +0100 Original-Received: from localhost ([127.0.0.1]:38845 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LFJY3-0002rU-Nu for ged-emacs-devel@m.gmane.org; Tue, 23 Dec 2008 21:32:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LFJXy-0002rL-JV for emacs-devel@gnu.org; Tue, 23 Dec 2008 21:32:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LFJXx-0002r9-AP for emacs-devel@gnu.org; Tue, 23 Dec 2008 21:32:30 -0500 Original-Received: from [199.232.76.173] (port=39315 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LFJXx-0002r6-74 for emacs-devel@gnu.org; Tue, 23 Dec 2008 21:32:29 -0500 Original-Received: from orlando.hostforweb.net ([216.246.45.90]:41852) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LFJXw-0007if-LH for emacs-devel@gnu.org; Tue, 23 Dec 2008 21:32:28 -0500 Original-Received: from localhost ([127.0.0.1]:45155) by orlando.hostforweb.net with esmtpa (Exim 4.69) (envelope-from ) id 1LFJXo-0005Tj-O0; Tue, 23 Dec 2008 20:32:22 -0600 Mail-Followup-To: Ami Fischman , ding@gnus.org, emacs-devel@gnu.org, emacs-jabber-general@lists.sourceforge.net X-Hashcash: 1:20:081224:ding@gnus.org::2y+DVvKQtw63YyBi:00007O9W X-Hashcash: 1:20:081224:ami@fischman.org::LlJG4LaiAo7YOfUb:007g/ X-Hashcash: 1:20:081224:emacs-devel@gnu.org::Mr51Ccoq9m19qK60:0000000000000000000000000000000000000000000C2P X-Hashcash: 1:20:081224:emacs-jabber-general@lists.sourceforge.net::b4jqwzhrkrZM9QAb:0000000000000000000AV/9 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:DfEGSVk39mqc72QrALWkfOwXU3c= X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:107259 gmane.emacs.gnus.general:67979 gmane.emacs.jabber.general:831 Archived-At: >>>>> Reiner Steib wrote: > However, I wonder if the more general patch suggested by David Engster > is better. Does anyone see a problem with it? > Ami, does David's patch solve your problem? > --- a/lisp/gnus-sum.el > +++ b/lisp/gnus-sum.el > @@ -3831,6 +3831,7 @@ This function is intended to be used in > (and (consp elem) ; Has to be a cons. > (consp (cdr elem)) ; The cdr has to be a list. > (symbolp (car elem)) ; Has to be a symbol in there. > + (boundp (car elem)) ; Has to be already bound > (not (memq (car elem) vars)) > (ignore-errors ; So we set it. > (push (car elem) vars) >>>>> In Katsumi Yamaoka wrote: > Cool! But I agree not to use it. :) But I found no evil with that patch so far. Variables like gnus-* globally bound need to get to be buffer-local but it's harmless. Moreover, those parameters have been to be set as (VAR VAL), not (VAR . VAL). OTOH, parameters used as just parameters, e.g. `timestamp', should not need to be bound; those are set in the `gnus-parameters' variable or the newsrc database. Only one anxiety is the case that a user or some program binds such a variable, but the fault will lie with the user or what should be complained will be the program. So, I've installed David Engster's patch with a comment: http://article.gmane.org/gmane.emacs.gnus.commits/6091 Regards,