gnus-summary-save-in-pipe does not pipe raw article

gnus-summary-save-in-pipe does not pipe raw article

[Graham Murray]

Until recently, following the example in the documentation I was able to
"report" spam articles using spamassassin using the function

(defun my-gnus-raze-spam ()
  "Invoke SpamAssassin reporting , then mark it as expirable."
  (interactive)
  (gnus-summary-show-raw-article)
  (gnus-summary-save-in-pipe "spamassassin -r")
  (gnus-summary-mark-as-expirable 1))

Now using the latest cvs of ngnus, the raw article is not sent to the
pipe.

Re: gnus-summary-save-in-pipe does not pipe raw article

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

>>>>> In <87mykes2g8.fsf@newton.gmurray.org.uk>
>>>>>	Graham Murray <graham@gmurray.org.uk> wrote:

> Until recently, following the example in the documentation I was able to
> "report" spam articles using spamassassin using the function

> (defun my-gnus-raze-spam ()
>   "Invoke SpamAssassin reporting , then mark it as expirable."
>   (interactive)
>   (gnus-summary-show-raw-article)
>   (gnus-summary-save-in-pipe "spamassassin -r")
>   (gnus-summary-mark-as-expirable 1))

> Now using the latest cvs of ngnus, the raw article is not sent to the
> pipe.

Try this instead:


[-- Attachment #2: Type: application/emacs-lisp, Size: 376 bytes --]

[-- Attachment #3: Type: text/plain, Size: 135 bytes --]


;; cf. (info "(gnus)Saving Articles")

Or if you use `gnus-summary-save-in-pipe' for only this feature
simply you can do as follows:


[-- Attachment #4: Type: application/emacs-lisp, Size: 271 bytes --]

[-- Attachment #5: Type: text/plain, Size: 0 bytes --]

Re: gnus-summary-save-in-pipe does not pipe raw article

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]

>>>>> Gabor Z. Papp wrote:

>| (defun my-gnus-raze-spam ()
>|   "Invoke SpamAssassin reporting , then mark it as expirable."
>|   (interactive)
>|   (let ((decode (get 'gnus-summary-save-in-pipe :decode)))
>|     (put 'gnus-summary-save-in-pipe :decode nil)
>|     (unwind-protect
>| 	(gnus-summary-save-in-pipe "spamassassin -r")
>|       (put 'gnus-summary-save-in-pipe :decode decode)))
>|   (gnus-summary-mark-as-expirable 1))

> With this code, using "cat | /path/to/command" instead of
> "spamassassin -r" I can't pipe the full raw article with headers, only
> with From/To/Subject/Date headers. What I'm missing?

Oops, I forgot to take account of the `:headers' property for
`gnus-summary-save-in-pipe'.  I've fixed it in the Gnus CVS trunk.
If you think nothing of updating your Gnus, update and install it,
and use the following instead:


[-- Attachment #2: Type: application/emacs-lisp, Size: 562 bytes --]

[-- Attachment #3: Type: text/plain, Size: 103 bytes --]


Otherwise, you can use this workaround (which can be used with
both the fixed Gnus and the old one):


[-- Attachment #4: Type: application/emacs-lisp, Size: 605 bytes --]

Re: gnus-summary-save-in-pipe does not pipe raw article

[Gabor Z. Papp]

* Katsumi Yamaoka <yamaoka@jpl.org>:

| Oops, I forgot to take account of the `:headers' property for
| `gnus-summary-save-in-pipe'.  I've fixed it in the Gnus CVS trunk.

Thanks, seems like ok. Only one problem left, earlier with the code
below I was able to mark more articles and pipe them one by one in batch:

(defun gzp-pipe-spam (&optional n)
  (interactive "P")
  (let* ( (pipe (format "cat | /path/to/cmd"))
         )

    (save-excursion
      (dolist (article (gnus-summary-work-articles n))
       (gnus-summary-goto-subject article)
       (gnus-summary-show-raw-article)
       (gnus-summary-save-in-pipe :decode nil)
       (gnus-summary-save-in-pipe pipe)
       (gnus-summary-show-article)
       )))
  (gnus-summary-expand-window))

The current code does only one article even I mark more.
I can't fix it, could someone help? :-)

(defun gzp-pipe-spam (&optional n)
  (interactive "P")
  (let  ((decode (get 'gnus-summary-save-in-pipe :decode))
        (headers (get 'gnus-summary-save-in-pipe :headers))
        (gnus-save-all-headers t))
    (put 'gnus-summary-save-in-pipe :decode nil)
    (put 'gnus-summary-save-in-pipe :headers nil)
    (unwind-protect
        (gnus-summary-save-in-pipe "cat | /path/to/cmd")
      (put 'gnus-summary-save-in-pipe :decode decode)
      (put 'gnus-summary-save-in-pipe :headers headers))
     (gnus-summary-expand-window))
  )

Re: gnus-summary-save-in-pipe does not pipe raw article

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

>>>>> Gabor Z. Papp wrote:

> Thanks, seems like ok.

Thank you for verifying it.

> Only one problem left, earlier with the code below I was able to
> mark more articles and pipe them one by one in batch:

> (defun gzp-pipe-spam (&optional n)
>   (interactive "P")
>   (let* ( (pipe (format "cat | /path/to/cmd"))
>          )

>     (save-excursion
>       (dolist (article (gnus-summary-work-articles n))
>        (gnus-summary-goto-subject article)
>        (gnus-summary-show-raw-article)
>        (gnus-summary-save-in-pipe :decode nil)
>        (gnus-summary-save-in-pipe pipe)
>        (gnus-summary-show-article)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Isn't it unnecessary?
>        )))
>   (gnus-summary-expand-window))
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ That's a good idea.

> The current code does only one article even I mark more.
> I can't fix it, could someone help? :-)

Ok.  Could you try this one?


[-- Attachment #2: Type: application/emacs-lisp, Size: 660 bytes --]

Re: gnus-summary-save-in-pipe does not pipe raw article

[Gabor Z. Papp]

* Katsumi Yamaoka <yamaoka@jpl.org>:

| Ok.  Could you try this one?

Thank you, it works as I excepted.

Re: gnus-summary-save-in-pipe does not pipe raw article

[Dan Christensen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

>   (let* ((pipe (format "cat | /path/to/cmd"))
>
> 	 (decode (get 'gnus-summary-save-in-pipe :decode))
> 	 (headers (get 'gnus-summary-save-in-pipe :headers))
> 	 (gnus-save-all-headers t)
>
> 	 )
>     (put 'gnus-summary-save-in-pipe :decode nil)
>     (put 'gnus-summary-save-in-pipe :headers nil)
>     (unwind-protect
> 	(save-excursion
> 	  (dolist (article (gnus-summary-work-articles n))
> 	    (gnus-summary-goto-subject article)
> 	    (gnus-summary-save-in-pipe pipe)
> 	    ))
>       (put 'gnus-summary-save-in-pipe :decode decode)
>       (put 'gnus-summary-save-in-pipe :headers headers)))
>   (gnus-summary-expand-window))

Maybe all but two or three lines of the above should be made into a
function gnus-summary-save-in-pipe-raw?  Or maybe the existing function
gnus-summary-save-in-pipe should take an optional "raw" argument to get
this behaviour?  Forcing the caller to jump through the above hoops
seems excessive...

Dan

Re: gnus-summary-save-in-pipe does not pipe raw article

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 1341 bytes --]

>>>>> Dan Christensen wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:

>>   (let* ((pipe (format "cat | /path/to/cmd"))
>>
>> 	 (decode (get 'gnus-summary-save-in-pipe :decode))
>> 	 (headers (get 'gnus-summary-save-in-pipe :headers))
>> 	 (gnus-save-all-headers t)
>>
>> 	 )
>>     (put 'gnus-summary-save-in-pipe :decode nil)
>>     (put 'gnus-summary-save-in-pipe :headers nil)
>>     (unwind-protect
>> 	(save-excursion
>> 	  (dolist (article (gnus-summary-work-articles n))
>> 	    (gnus-summary-goto-subject article)
>> 	    (gnus-summary-save-in-pipe pipe)
>> 	    ))
>>       (put 'gnus-summary-save-in-pipe :decode decode)
>>       (put 'gnus-summary-save-in-pipe :headers headers)))
>>   (gnus-summary-expand-window))

> Maybe all but two or three lines of the above should be made into a
> function gnus-summary-save-in-pipe-raw?  Or maybe the existing function
> gnus-summary-save-in-pipe should take an optional "raw" argument to get
> this behaviour?  Forcing the caller to jump through the above hoops
> seems excessive...

That's good.  Thanks.  I've added to `gnus-summary-save-in-pipe'
the optional 2nd argument `raw' meaning:

,----
| Non-nil value for RAW overrides `:decode' and `:headers' properties
| and the raw article including all headers will be piped.
`----

So, now Gabor's function can be simplified into:


[-- Attachment #2: Type: application/emacs-lisp, Size: 284 bytes --]

Re: gnus-summary-save-in-pipe does not pipe raw article

[Lloyd Zusman]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

>>>>>> Dan Christensen wrote:
>> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>
>>>   (let* ((pipe (format "cat | /path/to/cmd"))
>>>
>>> 	 (decode (get 'gnus-summary-save-in-pipe :decode))
>>> 	 (headers (get 'gnus-summary-save-in-pipe :headers))
>>> 	 (gnus-save-all-headers t)
>>>
>>> 	 )
>>>     (put 'gnus-summary-save-in-pipe :decode nil)
>>>     (put 'gnus-summary-save-in-pipe :headers nil)
>>>     (unwind-protect
>>> 	(save-excursion
>>> 	  (dolist (article (gnus-summary-work-articles n))
>>> 	    (gnus-summary-goto-subject article)
>>> 	    (gnus-summary-save-in-pipe pipe)
>>> 	    ))
>>>       (put 'gnus-summary-save-in-pipe :decode decode)
>>>       (put 'gnus-summary-save-in-pipe :headers headers)))
>>>   (gnus-summary-expand-window))
>
>> Maybe all but two or three lines of the above should be made into a
>> function gnus-summary-save-in-pipe-raw?  Or maybe the existing function
>> gnus-summary-save-in-pipe should take an optional "raw" argument to get
>> this behaviour?  Forcing the caller to jump through the above hoops
>> seems excessive...
>
> That's good.  Thanks.  I've added to `gnus-summary-save-in-pipe'
> the optional 2nd argument `raw' meaning:
>
> ,----
> | Non-nil value for RAW overrides `:decode' and `:headers' properties
> | and the raw article including all headers will be piped.
> `----
>
> So, now Gabor's function can be simplified into:
>
> (defun gzp-pipe-spam (&optional n)
>   (interactive "P")
>   (let ((pipe (format "cat | /path/to/cmd")))
........................^^^^^^^

<not-to-be-taken-too-seriously>

Just a (very!) small nit. Why is `cat' being used here? Am I missing
something? This looks like another recipient of the UUOC Award ("Useless
Use of Cat"):

  http://en.wikipedia.org/wiki/Cat_(Unix)#cat_and_UUOC

And for that matter, the `format' function is equally superfluous,
as the following is equivalent and faster:

  (let ((pipe "/path/to/cmd"))

</not-to-be-taken-too-seriously>
                         
>     (save-excursion
>       (dolist (article (gnus-summary-work-articles n))
> 	(gnus-summary-goto-subject article)
> 	(gnus-summary-save-in-pipe pipe t))))
>   (gnus-summary-expand-window))

-- 
 Lloyd Zusman
 ljz@asfast.com
 God bless you.

Re: gnus-summary-save-in-pipe does not pipe raw article

[Katsumi Yamaoka]

>>>>> Lloyd Zusman wrote:

>> (defun gzp-pipe-spam (&optional n)
>>   (interactive "P")
>>   (let ((pipe (format "cat | /path/to/cmd")))
> ........................^^^^^^^

<not-to-be-taken-too-seriously>

> Just a (very!) small nit. Why is `cat' being used here? Am I missing
> something? This looks like another recipient of the UUOC Award ("Useless
> Use of Cat"):

>   http://en.wikipedia.org/wiki/Cat_(Unix)#cat_and_UUOC

> And for that matter, the `format' function is equally superfluous,
> as the following is equivalent and faster:

>   (let ((pipe "/path/to/cmd"))

I guessed that's just an example.  I believe what he actually
uses is more complicated and `format' and `let*' are really
needed there.  ;-)

</not-to-be-taken-too-seriously>

Re: gnus-summary-save-in-pipe does not pipe raw article

[Gabor Z. Papp]

* Katsumi Yamaoka <yamaoka@jpl.org>:

| >   (let ((pipe "/path/to/cmd"))

| I guessed that's just an example.  I believe what he actually
| uses is more complicated and `format' and `let*' are really
| needed there.  ;-)

No, I'm not speaking lisp, and got this part of code from the Net(TM).
Thanks Katsumi and Lloyd for the suggestions, I have corrected the
code, getting rid of let*, format and cat.

Re: gnus-summary-save-in-pipe does not pipe raw article

[Reiner Steib]

On Wed, Jul 23 2008, Katsumi Yamaoka wrote:

>   "Invoke SpamAssassin reporting , then mark it as expirable."

Can't `spam.el' be used for this?  There's some support for
spamassassin there.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: gnus-summary-save-in-pipe does not pipe raw article

[Graham Murray]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> On Wed, Jul 23 2008, Katsumi Yamaoka wrote:
>
>>   "Invoke SpamAssassin reporting , then mark it as expirable."
>
> Can't `spam.el' be used for this?  There's some support for
> spamassassin there.

spam.el only allows learning as spam (or ham) locally, it does not allow
for reporting to external systems such as DCC, razor, pyzor, and
spamcop. 

Re: gnus-summary-save-in-pipe does not pipe raw article

[Ted Zlatanov]

On Wed, 23 Jul 2008 21:24:15 +0100 Graham Murray <graham@gmurray.org.uk> wrote: 

GM> Reiner Steib <reinersteib+gmane@imap.cc> writes:
>> On Wed, Jul 23 2008, Katsumi Yamaoka wrote:
>> 
>>> "Invoke SpamAssassin reporting , then mark it as expirable."
>> 
>> Can't `spam.el' be used for this?  There's some support for
>> spamassassin there.

GM> spam.el only allows learning as spam (or ham) locally, it does not allow
GM> for reporting to external systems such as DCC, razor, pyzor, and
GM> spamcop. 

Have you seen spam-report.el?  Maybe it can be useful to you.  The
methods should be easily adaptable to other remote systems besides
what's there currently.

Ted