From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/63748 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] Make message-insert-citation-line works with nnrss groups Date: Fri, 15 Sep 2006 08:57:32 +0900 Organization: Emacsen advocacy group Message-ID: References: <87ejuekzhm.fsf@onosendai.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1158278545 1075 80.91.229.2 (15 Sep 2006 00:02:25 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 15 Sep 2006 00:02:25 +0000 (UTC) Cc: ding@gnus.org Original-X-From: ding-owner+m12275@lists.math.uh.edu Fri Sep 15 02:02:24 2006 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GO19t-00050z-VG for ding-account@gmane.org; Fri, 15 Sep 2006 02:02:18 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1GO19o-0004WQ-00; Thu, 14 Sep 2006 19:02:12 -0500 Original-Received: from nas02.math.uh.edu ([129.7.128.40]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1GO15b-0004WI-00 for ding@lists.math.uh.edu; Thu, 14 Sep 2006 18:57:51 -0500 Original-Received: from quimby.gnus.org ([80.91.227.211]) by nas02.math.uh.edu with esmtp (Exim 4.52) id 1GO15V-0002Qn-1i for ding@lists.math.uh.edu; Thu, 14 Sep 2006 18:57:49 -0500 Original-Received: from washington.hostforweb.net ([66.225.201.13]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1GO15O-0007Mn-00 for ; Fri, 15 Sep 2006 01:57:38 +0200 Original-Received: from [205.234.185.198] (port=53504 helo=mail.jpl.org) by washington.hostforweb.net with esmtpa (Exim 4.52) id 1GO162-00083B-HP; Thu, 14 Sep 2006 18:58:18 -0500 Original-To: Andrea Russo X-Hashcash: 1:20:060914:rast4ndy@gmail.com::kyc1brkvefWciTqE:000000000000000000000000000000000000000000036P+ X-Hashcash: 1:20:060914:ding@gnus.org::xYZY7xzHblspFcxp:00002rTY X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:IFUPZ0VA3lSUQUPTLdMa3DURHKU= X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - washington.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -2.5 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:63748 Archived-At: >>>>> In <87ejuekzhm.fsf@onosendai.org> Andrea Russo wrote: > There is a bug in `message-insert-citation-line' that happens when > trying to reply to an article in a nnrss group. > Various blogging software doesn't set a `From' header in blog posts, > so when gnus tries to cite the author of the post, it hits a `Wrong > type argument' error. I agree that's really a bug. > This patch tries to fix this. [...] > +2006-09-14 Andrea Russo > + > + * message.el (message-insert-citation-line): Check if the from header > + is nil. This may happens in articles from nnrss groups. In No Gnus, `message-insert-formated-citation-line' which is another candidate to `message-citation-line-function' should be fixed as well. Furthermore, any function that a user specified to that variable should suppose `From' might not be present in the `message-reply-headers' variable. Instead, how about making `From' default to `nobody'? Here's another patch to Gnus v5.11: --- message.el~ 2006-09-05 21:59:23 +0000 +++ message.el 2006-09-14 23:55:26 +0000 @@ -3280,7 +3280,7 @@ (message-narrow-to-head-1) (vector 0 (or (message-fetch-field "subject") "none") - (message-fetch-field "from") + (or (message-fetch-field "from") "nobody") (message-fetch-field "date") (message-fetch-field "message-id" t) (message-fetch-field "references") @@ -3329,7 +3329,7 @@ (message-narrow-to-head-1) (vector 0 (or (message-fetch-field "subject") "none") - (message-fetch-field "from") + (or (message-fetch-field "from") "nobody") (message-fetch-field "date") (message-fetch-field "message-id" t) (message-fetch-field "references")