Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: Erwan David <erwan@rail.eu.org>
Cc: bugs@gnus.org, ding@gnus.org
Subject: Re: Bad header deconding in supersede
Date: Tue, 05 Aug 2008 18:57:26 +0900	[thread overview]
Message-ID: <b4m8wvbzsvt.fsf@jpl.org> (raw)
In-Reply-To: <86vdyf524k.fsf@nez-casse.depot.rail.eu.org>

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]

>>>>> Erwan David wrote:
> No Gnus v0.11
> GNU Emacs 22.2.1 (x86_64-pc-freebsd, X toolkit, Xaw3d scroll bars)
>  of 2008-06-09 on nez-casse.depot.rail.eu.org
> 200 news-3.free.fr (4-2) NNRP Service Ready - newsmaster@proxad.net (posting ok)

> When I supersede an article, whose headers where sent in ISO-8859-1, they
> are presented as is, thus as \351 since it is not a valid utf-8
> character. This leads to wrong encoding in superseded message header
> when I do not catch this.

> There is no problem in the body treatment, only headers.

There's a similar problem in `gnus-summary-resend-message-edit'
and the patch attached below seems to solve it.  However I don't
want to install it now because it has to be verified further and
the next Emacs (containing Gnus v5.13, a.k.a. No Gnus) release
is around the corner.  So I'd add it to my TODO list instead.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 719 bytes --]

--- gnus-msg.el~	2008-06-11 21:40:58 +0000
+++ gnus-msg.el	2008-08-05 09:53:51 +0000
@@ -1283,6 +1283,7 @@
 	;; Get a normal message buffer.
 	(message-pop-to-buffer (message-buffer-name "Resend" to))
 	(insert-buffer-substring cur)
+	(article-decode-encoded-words)
 	(mime-to-mml)
 	(message-narrow-to-head-1)
 	;; Gnus will generate a new one when sending.
--- message.el~	2008-07-17 23:44:34 +0000
+++ message.el	2008-08-05 09:53:51 +0000
@@ -6838,6 +6838,7 @@
     ;; Get a normal message buffer.
     (message-pop-to-buffer (message-buffer-name "supersede"))
     (insert-buffer-substring cur)
+    (article-decode-encoded-words)
     (mime-to-mml)
     (message-narrow-to-head-1)
     ;; Remove unwanted headers.

       reply	other threads:[~2008-08-05  9:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <86vdyf524k.fsf@nez-casse.depot.rail.eu.org>
2008-08-05  9:57 ` Katsumi Yamaoka [this message]
2008-08-08 11:11   ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4m8wvbzsvt.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=bugs@gnus.org \
    --cc=ding@gnus.org \
    --cc=erwan@rail.eu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).