Re: [PATCH] Fix gnus-message-citation-mode for (S)XEmacs

[Katsumi Yamaoka <yamaoka@jpl.org>]

>>>>> In <v9r6ugwadx.fsf@marauder.physik.uni-ulm.de>
>>>>>	Reiner Steib <reinersteib+gmane@imap.cc> wrote:

> On Sun, Dec 31 2006, Steve Youngs wrote:

[...]

>>  (eval-when-compile (require 'cl))
>> +(eval-when-compile
>> +  (when (featurep 'xemacs)
>> +    (require 'easy-mmode))) ; for `define-minor-mode'

> Hm, I'm surprised that (S)XEmacs' byte-compiler doesn't complain in
> the first place.

I found the cause that building of Gnus with XEmacs 21.4 failed
as follows:

Compiling gnus/lisp/gnus-cite.el...
While compiling toplevel forms in file gnus/lisp/gnus-cite.el:
  !! Wrong type argument ((char-or-string-p nil))

In xemacs-base/easy-mmode.el, the `replace-regexp-in-string'
function is defined if it is not bound, and the
`define-minor-mode' macro uses it when compiling.  However,
lpath.el binds it to `ignore' before easy-mmode.el is loaded
(see dgnushack.el).  So, `define-minor-mode' uses the version of
`replace-regexp-in-string' that always returns nil.

I've removed `replace-regexp-in-string' from lpath.el in the
trunk temporarily.  However, I think the best way is to make
easy-mmode.el use `replace-in-string' instead of
`replace-regexp-in-string'.  That XEmacs easily provides the
Emacs functions causes confusion.

I've also done some minor fixes in the v5-10 branch and the
trunk.  They are mainly for only making the byte compiler
silent, don't influence the behavior of Gnus.

Regards,