From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/64212 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] Fix gnus-message-citation-mode for (S)XEmacs Date: Mon, 01 Jan 2007 16:26:16 +0900 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1167636505 26669 80.91.229.12 (1 Jan 2007 07:28:25 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 1 Jan 2007 07:28:25 +0000 (UTC) Original-X-From: ding-owner+M12735@lists.math.uh.edu Mon Jan 01 08:28:24 2007 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1H1Han-0007Wy-Mi for ding-account@gmane.org; Mon, 01 Jan 2007 08:28:21 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1H1HZW-00074K-6E; Mon, 01 Jan 2007 01:27:02 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1H1HZU-000745-S9 for ding@lists.math.uh.edu; Mon, 01 Jan 2007 01:27:00 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.63) (envelope-from ) id 1H1HZR-0000d3-CM for ding@lists.math.uh.edu; Mon, 01 Jan 2007 01:27:00 -0600 Original-Received: from washington.hostforweb.net ([66.225.201.13]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1H1HZQ-0007Tl-00 for ; Mon, 01 Jan 2007 08:26:56 +0100 Original-Received: from [218.118.2.103] (port=62263 helo=) by washington.hostforweb.net with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.52) id 1H1HYs-00018l-Rc for ding@gnus.org; Mon, 01 Jan 2007 01:26:25 -0600 Original-To: ding@gnus.org X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.92 (gnu/linux) Cancel-Lock: sha1:3L0IDfpxyRv//yTJjE+oo8TI314= X-Antivirus-Scanner: Clean mail though you should still use an Antivirus X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - washington.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:64212 Archived-At: >>>>> In >>>>> Reiner Steib wrote: > On Sun, Dec 31 2006, Steve Youngs wrote: [...] >> (eval-when-compile (require 'cl)) >> +(eval-when-compile >> + (when (featurep 'xemacs) >> + (require 'easy-mmode))) ; for `define-minor-mode' > Hm, I'm surprised that (S)XEmacs' byte-compiler doesn't complain in > the first place. I found the cause that building of Gnus with XEmacs 21.4 failed as follows: Compiling gnus/lisp/gnus-cite.el... While compiling toplevel forms in file gnus/lisp/gnus-cite.el: !! Wrong type argument ((char-or-string-p nil)) In xemacs-base/easy-mmode.el, the `replace-regexp-in-string' function is defined if it is not bound, and the `define-minor-mode' macro uses it when compiling. However, lpath.el binds it to `ignore' before easy-mmode.el is loaded (see dgnushack.el). So, `define-minor-mode' uses the version of `replace-regexp-in-string' that always returns nil. I've removed `replace-regexp-in-string' from lpath.el in the trunk temporarily. However, I think the best way is to make easy-mmode.el use `replace-in-string' instead of `replace-regexp-in-string'. That XEmacs easily provides the Emacs functions causes confusion. I've also done some minor fixes in the v5-10 branch and the trunk. They are mainly for only making the byte compiler silent, don't influence the behavior of Gnus. Regards,