Re: gnus-buffer-configuration and wide screens

[Katsumi Yamaoka <yamaoka@jpl.org>]

Eric Fraga wrote:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:
[...]
>>>| Debugger entered--Lisp error: (args-out-of-range 0)
>>>|   get-char-property(0 invisible)
>>>|   gnus-summary-show-thread()
>>>|   gnus-summary-scroll-up(1)
>>>|   call-interactively(gnus-summary-scroll-up nil nil)

>> Many summary commands assume the point to be in a summary buffer.

(It is necessary for such commands to work in the summary buffer,
 for looking up buffer-local variables, text properties, etc.)

> Sure but point is allowed to be in the article window and gnus works
> just fine with point there although obviously some commands are not
> available and/or work differently.

Some summary commands, that work even when launched from the article
buffer, make sure that themselves are in the summary buffer.
`gnus-summary-next-article' is the very case:

(defun gnus-summary-next-article (&optional unread subject backward push)
[...]
  ;; Make sure we are in the summary buffer.
  (unless (eq major-mode 'gnus-summary-mode)
    (set-buffer gnus-summary-buffer))

Gnus also offers the other way to make summary commands work in
the summary buffer certainly.  Though such commands are currently
`AS' and `C-d' only (cf. `gnus-article-read-summary-keys').
Moreover, this way is not effective to a summary command that runs
(gnus-configure-windows 'article), that will overturn the focus to
the article buffer if the article window configuration has `point'
in the `article' element.

For other summary commands causing an error when being invoked from
the article buffer, I guess there were no developers customizing
the window configuration so as to focus to the article buffer by
default.

>> So, some of the ones, that run (gnus-configure-windows 'article),
>> need to be modified like the following, I think.
>>
>>   (defun gnus-summary-* ()
>>     ...
>>     (gnus-configure-windows 'article)
>> + (gnus-eval-in-buffer-window gnus-summary-buffer
>>     ...)
>> + )

> I didn't understand this at all.  Sorry.

I meant:

--8<---------------cut here---------------start------------->8---
diff -au6 gnus-sum.el~ gnus-sum.el
--- gnus-sum.el~	2012-05-01 22:53:58.705382400 +0000
+++ gnus-sum.el	2012-05-08 00:18:22.105907100 +0000
@@ -7997,22 +7997,24 @@
 (defun gnus-summary-scroll-up (lines)
   "Scroll up (or down) one line current article.
 Argument LINES specifies lines to be scrolled up (or down if negative).
 If no article is selected, then the current article will be selected first."
   (interactive "p")
   (gnus-configure-windows 'article)
+  (gnus-eval-in-buffer-window gnus-summary-buffer
   (gnus-summary-show-thread)
   (when (eq (gnus-summary-select-article nil nil 'pseudo) 'old)
     (gnus-eval-in-buffer-window gnus-article-buffer
       (cond ((> lines 0)
 	     (when (gnus-article-next-page lines)
 	       (gnus-message 3 "End of message")))
 	    ((< lines 0)
 	     (gnus-article-prev-page (- lines))))))
   (gnus-summary-recenter)
   (gnus-summary-position-point))
+  )
 
 (defun gnus-summary-scroll-down (lines)
   "Scroll down (or up) one line current article.
 Argument LINES specifies lines to be scrolled down (or up if negative).
 If no article is selected, then the current article will be selected first."
   (interactive "p")
--8<---------------cut here---------------end--------------->8---

This should fix a bug that you first posted.  But it's easy to
imagine summary commands that should be fixed are not only this.

> My question is why cannot point be placed in the article window
> automatically using the gnus configuration settings?  I can obviously
> display the article and then immediately hit "h" to put point in the
> article window and gnus works fine when I do so.