From: Katsumi Yamaoka <yamaoka@jpl.org>
To: Adam W <adam_w67@yahoo.com>
Cc: ding@gnus.org
Subject: Re: maildir and ssh
Date: Thu, 24 Nov 2011 09:13:26 +0900 [thread overview]
Message-ID: <b4maa7m8jix.fsf@jpl.org> (raw)
In-Reply-To: <1321992427.10810.YahooMailNeo@web29910.mail.ird.yahoo.com>
Adam W wrote:
> I found a bug in gnus. In mail-source.el, mail-source-fetch-dir there
> is a call to delete-file. Gnus checks this call to return non-nil.
> When using a remote ssh maildir via ssh, delete-file returns nil though.
> Here is the fixed function:
> (defun mail-source-fetch-maildir (source callback)
--- mail-source.el~ 2011-04-05 05:00:09 +0000
+++ mail-source.el 2011-11-22 20:07:07 +0000
@@ -1038 +1038,2 @@
- (delete-file file)))))
+ (delete-file file)
+ nil))))
I believe you're right, it's a mail-source bug. Any Lisp code
should never expect the return value of `delete-file' since it
is not documented. I verified it returns nil for a local file
but t for a remote file using ssh[1]:
(delete-file "/ssh:localhost:/home/yamaoka/FILE")
Fixed in the Gnus trunk and the Emacs trunk.
[1] Note that tramp runs "rm -f" (that is hard-coded) in a remote
system, so `delete-file' always returns t even if a file does not
exist.
next prev parent reply other threads:[~2011-11-24 0:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 20:07 Adam W
2011-11-23 18:52 ` Adam
2011-11-24 0:13 ` Katsumi Yamaoka [this message]
2011-11-24 5:32 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4maa7m8jix.fsf@jpl.org \
--to=yamaoka@jpl.org \
--cc=adam_w67@yahoo.com \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).