From: Katsumi Yamaoka <yamaoka@jpl.org>
To: Brian Sniffen <bts@evenmere.org>
Cc: bugs@gnus.org, ding@gnus.org
Subject: Re: Gnus-draft's handling of gnus-message-setup-hook
Date: Tue, 03 Mar 2009 12:01:20 +0900 [thread overview]
Message-ID: <b4mab839unz.fsf@jpl.org> (raw)
In-Reply-To: <cb6c0eda0903021831i739f5303i29e140a7e6a37c4a@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
>>>>> Brian Sniffen wrote:
> My gnus-message-setup-hook is just (mml-secure-message-sign-pgpauto
> turn-on-filladapt-mode). I found the problem from the following sequence of
> actions:
> gnus
> gnus-agent-toggle-plugged
> gnus-group-mail
> (write a message to another account of mine, observing the <#secure method=
> pgpauto mode=sign> tag at the top)
> message-send-and-exit
> (type a passphrase for the GPG signature)
> gnus-agent-toggle-plugged
> gnus-group-send-queue
> While sending, each message is opened and mml-secure-message-sign-pgpauto is
> run. It adds another <#secure ...> MML tag to the top of the message, above
.> the -----BEGIN PGP... header. Because that MML tag contains a '=' character,
> it is not Quoted-Printable compliant. Even if the whole thing were sent with
> 7bit encoding, it would be unaesthetic to have an MML tag at the top of each
> message!
> When I follow the sequence of commands above, the extra MML tag is visible on
> the received message. Is it not for you? I suppose it's possible that the
> bug I'm seeing is more deeply buried, and I've only accidentally closed it off
> here.
> -Brian
Confirmed. Thank you for the explanation. I've installed your
patch in the Gnus trunk with the `tiny change' flag.
Regards,
> On Mon, Mar 2, 2009 at 9:00 PM, Katsumi Yamaoka <yamaoka@jpl.org> wrote:
>>>>>> Brian Sniffen wrote:
>> The wonderful offline-queue support in gnus-draft handles
>> message-setup-hook differently from gnus-message-setup-hook. I found
>> this when it caused an MML tag to escape into a message tagged as
>> quoted-printable. An over-eager malware filter outside my control
>> then rejected the improper-QP encoding.
>> -Brian
> Your fix looks necessary, however I don't see how to reproduce
> the bug. What does your `gnus-message-setup-hook' do? Isn't it
> a problem also when sending a message from the nndraft:drafts group?
>> diff -u -r7.24 gnus-draft.el
>> --- gnus-draft.el 22 Jan 2009 07:02:16 -0000 7.24
>> +++ gnus-draft.el 2 Mar 2009 19:21:37 -0000
>> @@ -146,6 +146,8 @@
>> message-send-hook))
>> (message-setup-hook (and (not is-queue)
>> message-setup-hook))
>> + (gnus-message-setup-hook (and (not is-queue)
>> + gnus-message-setup-hook))
>> (message-signature (and (not is-queue)
>> message-signature))
>> (gnus-agent-queue-mail (and (not is-queue)
>> --
>> Brian Sniffen
>> http://evenmere.org/~bts/
>> <bts@evenmere.org>
> --
> Brian Sniffen
> http://evenmere.org/~bts/
> <bts@evenmere.org>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
iEYEARECAAYFAkmsnYwACgkQLGVAwA4tiLlkQQCeIZtZIlYyhb4v0OqTJL1sOTLD
yJkAn0F2O5hVa0JZXifUNkO6rPH6eKu4
=9uop
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2009-03-03 3:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cb6c0eda0903021123i73ea9a10m75615d311f7f55e6@mail.gmail.com>
2009-03-03 2:00 ` Katsumi Yamaoka
[not found] ` <cb6c0eda0903021831i739f5303i29e140a7e6a37c4a@mail.gmail.com>
2009-03-03 3:01 ` Katsumi Yamaoka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4mab839unz.fsf@jpl.org \
--to=yamaoka@jpl.org \
--cc=bts@evenmere.org \
--cc=bugs@gnus.org \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).