From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/68346 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: Gnus-draft's handling of gnus-message-setup-hook Date: Tue, 03 Mar 2009 12:01:20 +0900 Organization: Emacsen advocacy group Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1236049381 32428 80.91.229.12 (3 Mar 2009 03:03:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Mar 2009 03:03:01 +0000 (UTC) Cc: bugs@gnus.org, ding@gnus.org To: Brian Sniffen Original-X-From: ding-owner+M16785@lists.math.uh.edu Tue Mar 03 04:04:17 2009 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1LeKvY-000702-OP for ding-account@gmane.org; Tue, 03 Mar 2009 04:04:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1LeKtZ-0000j3-6c; Mon, 02 Mar 2009 21:02:13 -0600 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1LeKtX-0000io-TB for ding@lists.math.uh.edu; Mon, 02 Mar 2009 21:02:11 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1LeKtU-0005v2-Ph for ding@lists.math.uh.edu; Mon, 02 Mar 2009 21:02:11 -0600 Original-Received: from orlando.hostforweb.net ([216.246.45.90]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1LeKtq-0001RT-00; Tue, 03 Mar 2009 04:02:30 +0100 Original-Received: from localhost ([127.0.0.1]:37770) by orlando.hostforweb.net with esmtpa (Exim 4.69) (envelope-from ) id 1LeKsu-0002QQ-Nm; Mon, 02 Mar 2009 21:01:33 -0600 X-Hashcash: 1:20:090303:bts@evenmere.org::bdDW6F0jxvZ5tc0F:0E9CA X-Hashcash: 1:20:090303:bugs@gnus.org::1/AkdkdsegfMM4O2:00000F+c X-Hashcash: 1:20:090303:ding@gnus.org::7VidoBQ+VdHrk6w/:00000LMw X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.91 (gnu/linux) Cancel-Lock: sha1:k/hcvwONjL6RandZTyevMr+ccCE= X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:68346 Archived-At: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 >>>>> Brian Sniffen wrote: > My gnus-message-setup-hook is just (mml-secure-message-sign-pgpauto > turn-on-filladapt-mode). I found the problem from the following sequence of > actions: > gnus > gnus-agent-toggle-plugged > gnus-group-mail > (write a message to another account of mine, observing the <#secure method= > pgpauto mode=sign> tag at the top) > message-send-and-exit > (type a passphrase for the GPG signature) > gnus-agent-toggle-plugged > gnus-group-send-queue > While sending, each message is opened and mml-secure-message-sign-pgpauto is > run. It adds another <#secure ...> MML tag to the top of the message, above .> the -----BEGIN PGP... header. Because that MML tag contains a '=' character, > it is not Quoted-Printable compliant. Even if the whole thing were sent with > 7bit encoding, it would be unaesthetic to have an MML tag at the top of each > message! > When I follow the sequence of commands above, the extra MML tag is visible on > the received message. Is it not for you? I suppose it's possible that the > bug I'm seeing is more deeply buried, and I've only accidentally closed it off > here. > -Brian Confirmed. Thank you for the explanation. I've installed your patch in the Gnus trunk with the `tiny change' flag. Regards, > On Mon, Mar 2, 2009 at 9:00 PM, Katsumi Yamaoka wrote: >>>>>> Brian Sniffen wrote: >> The wonderful offline-queue support in gnus-draft handles >> message-setup-hook differently from gnus-message-setup-hook. I found >> this when it caused an MML tag to escape into a message tagged as >> quoted-printable. An over-eager malware filter outside my control >> then rejected the improper-QP encoding. >> -Brian > Your fix looks necessary, however I don't see how to reproduce > the bug. What does your `gnus-message-setup-hook' do? Isn't it > a problem also when sending a message from the nndraft:drafts group? >> diff -u -r7.24 gnus-draft.el >> --- gnus-draft.el 22 Jan 2009 07:02:16 -0000 7.24 >> +++ gnus-draft.el 2 Mar 2009 19:21:37 -0000 >> @@ -146,6 +146,8 @@ >> message-send-hook)) >> (message-setup-hook (and (not is-queue) >> message-setup-hook)) >> + (gnus-message-setup-hook (and (not is-queue) >> + gnus-message-setup-hook)) >> (message-signature (and (not is-queue) >> message-signature)) >> (gnus-agent-queue-mail (and (not is-queue) >> -- >> Brian Sniffen >> http://evenmere.org/~bts/ >> > -- > Brian Sniffen > http://evenmere.org/~bts/ > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAkmsnYwACgkQLGVAwA4tiLlkQQCeIZtZIlYyhb4v0OqTJL1sOTLD yJkAn0F2O5hVa0JZXifUNkO6rPH6eKu4 =9uop -----END PGP SIGNATURE-----