Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
Subject: Re: [PATCH] Make message-insert-citation-line works with nnrss groups
Date: Sat, 16 Sep 2006 15:52:45 +0900	[thread overview]
Message-ID: <b4mac505mma.fsf@jpl.org> (raw)
In-Reply-To: <b4m7j06c87n.fsf@jpl.org>

>>>>> In <b4m7j06c87n.fsf@jpl.org> Katsumi Yamaoka wrote:

>>>>>> In <87ejuekzhm.fsf@onosendai.org> Andrea Russo wrote:

>> There is a bug in `message-insert-citation-line' that happens when
>> trying to reply to an article in a nnrss group.

>> Various blogging software doesn't set a `From' header in blog posts,
>> so when gnus tries to cite the author of the post, it hits a `Wrong
>> type argument' error.

> I agree that's really a bug.

>> This patch tries to fix this.

> [...]

>> +2006-09-14  Andrea Russo  <rast4ndy@gmail.com>
>> +
>> +	* message.el (message-insert-citation-line): Check if the from header
>> +	is nil.  This may happens in articles from nnrss groups.

> In No Gnus, `message-insert-formated-citation-line' which is
> another candidate to `message-citation-line-function' should be
> fixed as well.  Furthermore, any function that a user specified
> to that variable should suppose `From' might not be present in
> the `message-reply-headers' variable.  Instead, how about making
> `From' default to `nobody'?  Here's another patch to Gnus v5.11:

There's neither a followup nor a comment, but I've installed the
changes in both the trunk and the v5-10 branch.



  reply	other threads:[~2006-09-16  6:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-14 19:41 Andrea Russo
2006-09-14 23:57 ` Katsumi Yamaoka
2006-09-16  6:52   ` Katsumi Yamaoka [this message]
2006-09-16 10:50   ` Andrea Russo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4mac505mma.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).