From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/63750 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] Make message-insert-citation-line works with nnrss groups Date: Sat, 16 Sep 2006 15:52:45 +0900 Message-ID: References: <87ejuekzhm.fsf@onosendai.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1158389881 25343 80.91.229.2 (16 Sep 2006 06:58:01 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 16 Sep 2006 06:58:01 +0000 (UTC) Original-X-From: ding-owner+m12277@lists.math.uh.edu Sat Sep 16 08:57:59 2006 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GOU7i-0005XP-TK for ding-account@gmane.org; Sat, 16 Sep 2006 08:57:59 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1GOU7c-0006Gj-00; Sat, 16 Sep 2006 01:57:52 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1GOU33-0006Ge-00 for ding@lists.math.uh.edu; Sat, 16 Sep 2006 01:53:09 -0500 Original-Received: from quimby.gnus.org ([80.91.227.211]) by mx1.math.uh.edu with esmtp (Exim 4.52) id 1GOU32-0005KH-92 for ding@lists.math.uh.edu; Sat, 16 Sep 2006 01:53:09 -0500 Original-Received: from washington.hostforweb.net ([66.225.201.13]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1GOU2w-0004I7-00 for ; Sat, 16 Sep 2006 08:53:02 +0200 Original-Received: from softbank218118002103.bbtec.net ([218.118.2.103]:65133 helo=) by washington.hostforweb.net with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.52) id 1GOU3t-0005hc-Cs; Sat, 16 Sep 2006 01:54:02 -0500 Original-To: ding@gnus.org, Andrea Russo X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:p1v/iZwvSWJUnN+Vz9VF/T+Mu5w= X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - washington.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -2.6 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:63750 Archived-At: >>>>> In Katsumi Yamaoka wrote: >>>>>> In <87ejuekzhm.fsf@onosendai.org> Andrea Russo wrote: >> There is a bug in `message-insert-citation-line' that happens when >> trying to reply to an article in a nnrss group. >> Various blogging software doesn't set a `From' header in blog posts, >> so when gnus tries to cite the author of the post, it hits a `Wrong >> type argument' error. > I agree that's really a bug. >> This patch tries to fix this. > [...] >> +2006-09-14 Andrea Russo >> + >> + * message.el (message-insert-citation-line): Check if the from header >> + is nil. This may happens in articles from nnrss groups. > In No Gnus, `message-insert-formated-citation-line' which is > another candidate to `message-citation-line-function' should be > fixed as well. Furthermore, any function that a user specified > to that variable should suppose `From' might not be present in > the `message-reply-headers' variable. Instead, how about making > `From' default to `nobody'? Here's another patch to Gnus v5.11: There's neither a followup nor a comment, but I've installed the changes in both the trunk and the v5-10 branch.