Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
Subject: Re: code diff between trunk and 5.10
Date: Fri, 17 Feb 2006 07:55:45 +0900	[thread overview]
Message-ID: <b4maccq6hhq.fsf@jpl.org> (raw)
In-Reply-To: <61d5hnjf62.fsf@fencepost.gnu.org>

>>>>> In <61d5hnjf62.fsf@fencepost.gnu.org> Miles Bader wrote:

> lisp/gnus-art.el has the following difference between the two branches,
> inside `article-strip-banner'; the code is the same, except that in the
> trunk, `article-really-strip-banner' is called from the "throw", whereas in
> 5.10 it's unconditionally called.  As the non-throw case presumably only
> results in nil, the two methods may actually be equivalent in effect.

> Is this difference intentional, or just an accident?

TSUCHIYA-san changed it in the trunk so that
`article-really-strip-banner' might be called only when the
regexp match is made.  It reduces unnecessary funcalls and will
make it slightly faster.  I didn't merge it into the v5-10
branch yesterday since those differences seem to be very little,
though.  If it is better to make them the same for the
convenience of management, I'll do it.

revision 7.30
date: 2004/05/06 13:34:04;  author: tsuchiya;  state: Exp;  lines: +14 -3
(article-strip-banner): Use MIME-encoded from fields
instead of MIME-decoded from fields when checking
`gnus-article-address-banner-alist', instead of calling
`gnus-fetch-original-field'.
----------------------------
revision 7.29
date: 2004/05/06 01:41:33;  author: tsuchiya;  state: Exp;  lines: +8 -12
(article-strip-banner): Use original from fields instead of
MIME-decoded from fields, when checking `gnus-article-address-banner-alist'.
----------------------------
revision 7.28



  reply	other threads:[~2006-02-16 22:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-16 19:07 Miles Bader
2006-02-16 22:55 ` Katsumi Yamaoka [this message]
2006-02-17  0:08   ` Miles Bader
2006-02-17  0:17     ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4maccq6hhq.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).