From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/62011 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: code diff between trunk and 5.10 Date: Fri, 17 Feb 2006 07:55:45 +0900 Organization: Emacsen advocacy group Message-ID: References: <61d5hnjf62.fsf@fencepost.gnu.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1140130834 26377 80.91.229.2 (16 Feb 2006 23:00:34 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 16 Feb 2006 23:00:34 +0000 (UTC) Original-X-From: ding-owner+m10539@lists.math.uh.edu Fri Feb 17 00:00:32 2006 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F9s6p-0005oa-Ew for ding-account@gmane.org; Fri, 17 Feb 2006 00:00:24 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1F9s6g-0007XC-00; Thu, 16 Feb 2006 17:00:14 -0600 Original-Received: from nas01.math.uh.edu ([129.7.128.39]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1F9s2V-0007X6-00 for ding@lists.math.uh.edu; Thu, 16 Feb 2006 16:55:55 -0600 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas01.math.uh.edu with esmtp (Exim 4.52) id 1F9s2S-0006hk-Oj for ding@lists.math.uh.edu; Thu, 16 Feb 2006 16:55:54 -0600 Original-Received: from minsk.hostforweb.net ([66.225.201.21]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1F9s2Q-00087K-00 for ; Thu, 16 Feb 2006 23:55:51 +0100 Original-Received: from [205.234.212.150] (helo=mail.yamaoka.cc) by minsk.hostforweb.net with esmtpa (Exim 4.52) id 1F9s2T-0004p8-Sv for ding@gnus.org; Thu, 16 Feb 2006 16:55:54 -0600 Original-To: ding@gnus.org X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:WvZAaRuZ9qbgwIlh4wR6FImTTrE= X-Hashcash: 1:20:060216:ding@gnus.org::SMD80tkN8GpBi9uf:00000XJc X-Antivirus-Scanner: Clean mail though you should still use an Antivirus X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - minsk.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -2.5 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:62011 Archived-At: >>>>> In <61d5hnjf62.fsf@fencepost.gnu.org> Miles Bader wrote: > lisp/gnus-art.el has the following difference between the two branches, > inside `article-strip-banner'; the code is the same, except that in the > trunk, `article-really-strip-banner' is called from the "throw", whereas in > 5.10 it's unconditionally called. As the non-throw case presumably only > results in nil, the two methods may actually be equivalent in effect. > Is this difference intentional, or just an accident? TSUCHIYA-san changed it in the trunk so that `article-really-strip-banner' might be called only when the regexp match is made. It reduces unnecessary funcalls and will make it slightly faster. I didn't merge it into the v5-10 branch yesterday since those differences seem to be very little, though. If it is better to make them the same for the convenience of management, I'll do it. revision 7.30 date: 2004/05/06 13:34:04; author: tsuchiya; state: Exp; lines: +14 -3 (article-strip-banner): Use MIME-encoded from fields instead of MIME-decoded from fields when checking `gnus-article-address-banner-alist', instead of calling `gnus-fetch-original-field'. ---------------------------- revision 7.29 date: 2004/05/06 01:41:33; author: tsuchiya; state: Exp; lines: +8 -12 (article-strip-banner): Use original from fields instead of MIME-decoded from fields, when checking `gnus-article-address-banner-alist'. ---------------------------- revision 7.28