Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: ding@gnus.org
Subject: Re: fix for bad temporary value for gnus-buffer-configuration
Date: Thu, 03 Sep 2009 08:16:19 +0900	[thread overview]
Message-ID: <b4mbpltvsxo.fsf@jpl.org> (raw)
In-Reply-To: <vxk4orpktld.fsf@awol.kleinpaste.org>

>>>>> Karl Kleinpaste wrote:
> Consequent to needing a frame-width-sensitive change to my
> gnus-buffer-configuration choices due to using a really small display
> (65x15), I discovered that gnus-buffer-configuration causes trouble if
> the 'article selection element displays no Summary.  Code in gnus-art.el
> needs a visible summary, and if that's not available, it inserts a
> temporary value.  The problem is that the temporary value is missing a
> needed level of parenthesization.  It looks like this code was never
> tested.

> This can be checked by seeing what happens after...
>   (gnus-add-configuration
>    '(article
>      (vertical 1.0 (article 1.0 point))))       ;; no summary displayed
> ...if you then try to update an already-displayed article using `W w' or
> switch its MIMEd plain -vs- html displays with `b'.

> Would someone review to make sure this is sane, and commit it if so?

[...]

I've confirmed the bug and installed your patch in the Gnus trunk.
Thanks!



      reply	other threads:[~2009-09-02 23:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-30 19:08 Karl Kleinpaste
2009-09-02 23:16 ` Katsumi Yamaoka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4mbpltvsxo.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).