From: Katsumi Yamaoka <yamaoka@jpl.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: bugs@gnus.org, ding@gnus.org, emacs-devel@gnu.org
Subject: Re: Why multibyte for original-article buffer
Date: Fri, 29 Feb 2008 14:44:14 +0900 [thread overview]
Message-ID: <b4mbq6048r5.fsf@jpl.org> (raw)
In-Reply-To: <jwv8x145xjy.fsf-monnier+emacs@gnu.org>
>>>>> Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> Indeed, I see that. The patch below will fix it.
It works.
> - (insert-buffer-substring gnus-original-article-buffer)
> + ;; `insert-buffer-substring' would incorrectly use the
> + ;; equivalent of string-make-multibyte which amounts to decoding
> + ;; with locale-coding-system, causing failure of
> + ;; subsequent decoding.
> + (insert (mm-string-to-multibyte
> + (with-current-buffer gnus-original-article-buffer
> + (buffer-substring (point-min) (point-max)))))
This might be the most suitable occasion to decode raw data into
the human readable ones rather than only converting the multibyteness.
It suggests there will also be such items lying about here and
there. Though I think it should be done for the second step.
> Yes, the Gnus code is full of such things. I suggest it's time to take
> a step back and think about how things *should* work. Then change the
> parts for which we know how they should work. This will introduce bugs,
> but then we'll know that the bugs are elsewhere and that fixing them
> will get us closer to a good solution.
Great. I agree with installing those two changes as the first
step, though it might force non-ASCII people to live hard with
No Gnus for a while, I will one by one fix or at least report
things caused by it.
Regards,
next prev parent reply other threads:[~2008-02-29 5:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <jwvd4qg3nfg.fsf-monnier+emacs@gnu.org>
2008-02-29 0:35 ` Katsumi Yamaoka
2008-02-29 4:22 ` Stefan Monnier
2008-02-29 5:44 ` Katsumi Yamaoka [this message]
2008-02-29 6:18 ` Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4mbq6048r5.fsf@jpl.org \
--to=yamaoka@jpl.org \
--cc=bugs@gnus.org \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).