Re: hashcash - buffer modification

[Katsumi Yamaoka <yamaoka@jpl.org>]

>>>>> In <quack.20061114T1548.lthmz6tmvyk@roar.cs.berkeley.edu>
>>>>>	Karl Chen wrote:

> Hi, I'm glad hashcash is now integrated and on by default.

> One thing that bothers me about the asynchronous payment
> insertion, which is otherwise awesome, is that it sets the message
> buffer modification bit.

> I use the advice below to get around it; how about integrating it
> into hashcash-insert-payment-async-2?

> (defadvice hashcash-insert-payment-async-2 (around kc-hashcash-set-notmodified
>                                                    (buffer &rest l)
>                                                    activate)
>   (let ((modified (buffer-modified-p buffer)))
>     ad-do-it
>     (save-excursion
>       (set-buffer buffer)
>       (set-buffer-modified-p modified))))

I see no oddness there.  I'll install the following change in
the trunk if no objection:

--8<---------------cut here---------------start------------->8---
--- hashcash.el~	2006-04-15 18:12:07 +0000
+++ hashcash.el	2006-11-15 04:57:42 +0000
@@ -247,7 +247,9 @@
 					hashcash-process-alist))
 	  (message-goto-eoh)
 	  (when pay
-	    (insert-before-markers "X-Hashcash: " pay)))))))
+	    (let ((modified (buffer-modified-p buffer)))
+	      (insert-before-markers "X-Hashcash: " pay)
+	      (set-buffer-modified-p modified))))))))
 
 (defun hashcash-cancel-async (&optional buffer)
   "Delete any hashcash processes associated with BUFFER.
--8<---------------cut here---------------end--------------->8---

BTW, how do you add hashcash headers when you write a mail from
scratch (i.e., the case where To and Cc have not been filled yet)?
I use `mail-add-payment', not `mail-add-payment-async'.

Regards,