Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: ding@gnus.org
Subject: Re: Mixing whitespace and topical changes
Date: Tue, 17 Apr 2007 17:05:17 +0900	[thread overview]
Message-ID: <b4md523tohu.fsf@jpl.org> (raw)
In-Reply-To: <muxhcrf4gmv.fsf@uzeb.lrde.epita.fr>

>>>>> In <muxhcrf4gmv.fsf@uzeb.lrde.epita.fr> Didier Verna wrote:

> Katsumi Yamaoka <yamaoka@jpl.org> wrote:

>> I did the same before, but now I keep clean only things that I
>> changed. It is enough for me that Lars ever said to me "Don't use
>> whitespace.el or equivalent when changing Gnus.". IIRC, he said he
>> agrees to make source code clean all together but it should be done
>> independently to topical changes.

>         Who's Lars ? ;-)

I honor him as the founder of Gnus.

>> So, I don't mix whitespace changes and topical changes as much as
>> possible. Or else, not only the maintainers who check the validity of
>> changes but also people who read CVS diffs will be bothered if there
>> are such changes.

>         But my point is that 1/ if all CVS committers keep files clean
> automatically, the situation would not happen, and 2/ even if it does,
> you don't have to see the whitespaces difference; there are options in
> diff and such to just ignore them.

Good point.  How do we urge all to do so?  For instance, all
should set `indent-tabs-mode' to t, all should add a whitespace
function to hooks, etc.  It doesn't seem to be easy to me to
achieve it, similar to persuading you not to use whitespace.el.
Otherwise, can it be realized using ``Local Variables''?

>> Making source code clean is generally good. But I think it should be
>> done line by line manually at least in Gnus. What do you think about
>> this?
>>
>> (insert "One space character is here>
>> 	")
>>
>> It is a bad habit of course, though.

>         You're gonna have to give me a more convincing example :-)

>> Let me write repeatedly; please don't use tabs in texi files.
>> Especially for sections in which the indentation is meaningful, like
>> @lisp ... @end lisp.

>         Again, please show me *precisely* a problematic example.

I've posted it.  See this article:

http://article.gmane.org/gmane.emacs.gnus.general/64465

Regards,



  reply	other threads:[~2007-04-17  8:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-11 19:05 Reiner Steib
2007-04-16 13:17 ` Didier Verna
2007-04-17  2:04   ` Katsumi Yamaoka
2007-04-17  7:14     ` Didier Verna
2007-04-17  8:05       ` Katsumi Yamaoka [this message]
2007-04-17  9:32         ` Didier Verna
2007-04-17  9:39           ` Didier Verna
2007-04-17 10:21           ` Katsumi Yamaoka
2007-04-17 23:42           ` Miles Bader
2007-04-18  8:50             ` Didier Verna
2007-04-18  9:15               ` Miles Bader
2007-04-17 17:25   ` Reiner Steib
2007-04-18  7:42     ` Didier Verna
2007-04-18  9:54       ` Didier Verna
2007-04-18 20:55       ` Reiner Steib
2007-04-19  7:17         ` Didier Verna
2007-04-19  7:39           ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4md523tohu.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).