Recent change in gnus-sum.el is bad for XEmacs

Recent change in gnus-sum.el is bad for XEmacs

[Katsumi Yamaoka]

>>>>> In <E1LL8wp-0008K2-4d@cvs.savannah.gnu.org> Glenn Morris wrote:
> CVSROOT:	/sources/emacs
> Module name:	emacs
> Changes by:	Glenn Morris <gm>	09/01/09 04:26:14

> Modified files:
> 	lisp/gnus      : ChangeLog gnus-sum.el

[...]

> +2009-01-09  Glenn Morris  <rgm@gnu.org>
> +
> +	* gnus-sum.el (gnus-summary-next-article): Replace last-command-char
> +	with last-command-event.
> +

[...]

> --- gnus-sum.el	9 Jan 2009 03:01:52 -0000	1.137
> +++ gnus-sum.el	9 Jan 2009 04:26:14 -0000	1.138
> @@ -7625,7 +7625,7 @@
>     (t
>      (unless (gnus-ephemeral-group-p gnus-newsgroup-name)
>        (gnus-summary-jump-to-group gnus-newsgroup-name))
> -    (let ((cmd last-command-char)
> +    (let ((cmd last-command-event)
>  	  (point
>  	   (with-current-buffer gnus-group-buffer
>  	     (point)))

This change will be merged to the Gnus trunk sooner or later and
then XEmacs will get not to work (I verified).  When typing the
SPC key, `last-command-event' will be `10' in Emacs, whereas it
will be the Lisp object `#<keypress-event space>' in XEmacs.
Because of this the form `(equal key cmd)' used in the function
`gnus-summary-walk-group-buffer' will never return t.  I have a
solution as follows:

--8<---------------cut here---------------start------------->8---
--- gnus-sum.el~	2009-01-06 21:59:24 +0000
+++ gnus-sum.el	2009-01-09 10:35:57 +0000
@@ -7696,7 +7696,9 @@
 	  (setq group (gnus-group-group-name))
 	  (switch-to-buffer obuf))
 	(setq ended nil))
-       ((equal key cmd)
+       ((equal key (if (featurep 'xemacs)
+		       (event-to-character cmd)
+		     cmd))
 	(if (or (not group)
 		(gnus-ephemeral-group-p gnus-newsgroup-name))
 	    (gnus-summary-exit)
--8<---------------cut here---------------end--------------->8---

However, I'm not sure it's ok in all cases.  Couldn't the change
revert?

Regards,

Re: Recent change in gnus-sum.el is bad for XEmacs

[Katsumi Yamaoka]

>>>>> Katsumi Yamaoka wrote:
>> +2009-01-09  Glenn Morris  <rgm@gnu.org>
>> +
>> +	* gnus-sum.el (gnus-summary-next-article): Replace last-command-char
>> +	with last-command-event.

> This change will be merged to the Gnus trunk sooner or later and
> then XEmacs will get not to work (I verified).  When typing the
> SPC key, `last-command-event' will be `10' in Emacs, whereas it
                                         ^^
Oops, it's `32' of course.  Sorry.

> will be the Lisp object `#<keypress-event space>' in XEmacs.
[...]
> Couldn't the change revert?

Re: Recent change in gnus-sum.el is bad for XEmacs

[Glenn Morris]

Katsumi Yamaoka wrote:

> This change will be merged to the Gnus trunk sooner or later and
> then XEmacs will get not to work (I verified).

Sorry, I tried to take account of XEmacs code, but obviously I missed
some places. Please fix as you see fit.

Re: Recent change in gnus-sum.el is bad for XEmacs

[Katsumi Yamaoka]

>>>>> In <hqr63cmmyd.fsf@fencepost.gnu.org>
>>>>>	Glenn Morris <rgm@gnu.org> wrote:
> Katsumi Yamaoka wrote:

> > This change will be merged to the Gnus trunk sooner or later and
> > then XEmacs will get not to work (I verified).

> Sorry, I tried to take account of XEmacs code, but obviously I missed
> some places. Please fix as you see fit.

I chose reverting.  Thanks.