From: Katsumi Yamaoka <yamaoka@jpl.org>
To: Michael Sperber <sperber@deinprogramm.de>
Cc: ding@gnus.org
Subject: Re: PATCH: Unbreak `mailcap-mailcap-entry-passes-test'
Date: Tue, 20 Oct 2015 20:11:49 +0900 [thread overview]
Message-ID: <b4mfv15iykq.fsf@jpl.org> (raw)
In-Reply-To: <y9leggpgb1c.fsf@deinprogramm.de>
On Tue, 20 Oct 2015 11:10:55 +0200, Michael Sperber wrote:
> I had to apply to attached patch to make mailcap work on XEmacs. I'm
> puzzled by this, as I think it should break mailcap for just about
> everyone. On the other hand, I don't see how the code (without) the
> patch could work as advertised.
> So if somebody could review (and maybe apply) it, that - again - would
> be much appreciated.
This is what I grasped of how mailcap.el does:
What is passed to mailcap-mailcap-entry-passes-test is an entry
of a mailcap file (user's or system's) like this:
image/*; xv %s; test=test -n "$DISPLAY"
This entry is parsed by mailcap-parse-mailcap into:
((viewer . "xv %s") (type . "image/*") (test . "test -n \"$DISPLAY\""))
It is passed to mailcap-mailcap-entry-passes-test as an argument,
and the result is added to mailcap-mime-data. Where the result is
((viewer . "xv %s") (type . "image/*") (test . t))
if $DISPLAY is not empty, otherwise:
((viewer . "xv %s") (type . "image/*") (test))
If your patch is applied, the `test' token will not be updated
whatever $DISPLAY is.
Regards,
next prev parent reply other threads:[~2015-10-20 11:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 9:10 Michael Sperber
2015-10-20 11:11 ` Katsumi Yamaoka [this message]
2015-10-20 11:51 ` Michael Sperber
2015-10-20 14:25 ` Katsumi Yamaoka
2015-10-20 15:55 ` Michael Sperber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4mfv15iykq.fsf@jpl.org \
--to=yamaoka@jpl.org \
--cc=ding@gnus.org \
--cc=sperber@deinprogramm.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).