Re: add a gnus-summary-pipe-output-default-command variable

[Katsumi Yamaoka <yamaoka@jpl.org>]

[-- Attachment #1: Type: text/plain, Size: 1634 bytes --]

>>>>> jidanni@jidanni.org wrote:

> gnus-summary-pipe-output needs a
> gnus-summary-pipe-output-default-command variable, for users who find
> themselves mostly piping to the same command. It should be prompted as
> (Default: blabla) in the minibuffer, so one could just hit RET if OK.

> (P.S., currently if one does a second pipe, but first removes (DEL
> DEL...) the first command replay that one it prompted with, it indeed
> still does that same first command again. Kind of scary.)

Currently the default command that appears in the minibuffer is
the value held by the internal varable `gnus-last-shell-command'
when you invoked the `gnus-summary-pipe-output' command or the
`gnus-summary-muttprint' command previously.  There is the
`gnus-summary-muttprint-program' variable as a user option that
specifies the default command used by `gnus-summary-muttprint',
however it might be unfair that there is no such option for
`gnus-summary-pipe-output'.  Moreover, the command "muttprint"
will be suggested as the default command even if you invoke
`gnus-summary-pipe-output' if you've used `gnus-summary-muttprint'
previously.

The attached patch does:

1. Introduce `gnus-summary-pipe-output-default-command' which
   overrides `gnus-last-shell-command' if it is non-nil.
2. Make `gnus-summary-muttprint' not modify
   `gnus-last-shell-command'.  `gnus-summary-muttprint-program'
   itself holds the modified value.

A non-nil value of `gnus-summary-pipe-output-default-command'
always overrides `gnus-last-shell-command'.  So, my worry is that
one might forget having set it.  WDYT?  I'll commit the changes
if no one comments.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1618 bytes --]

--- gnus-art.el~	2008-06-11 21:40:58 +0000
+++ gnus-art.el	2008-06-30 00:33:21 +0000
@@ -3968,7 +3968,9 @@
   (setq command (read-string
 		 "Print using command: " gnus-summary-muttprint-program
 		 nil gnus-summary-muttprint-program))
-  (gnus-summary-save-in-pipe command))
+  (let ((gnus-last-shell-command gnus-last-shell-command))
+    (gnus-summary-save-in-pipe command)
+    (setq gnus-summary-muttprint-program gnus-last-shell-command)))
 
 ;;; Article file names when saving.
 
--- gnus-sum.el~	2008-06-15 21:39:57 +0000
+++ gnus-sum.el	2008-06-30 00:33:21 +0000
@@ -1242,6 +1242,13 @@
   :group 'gnus-summary
   :type '(choice boolean regexp))
 
+(defcustom gnus-summary-pipe-output-default-command nil
+  "Command (and optional arguments) used by `gnus-summary-pipe-output'.
+The value will be used as the default command if it is non-nil."
+  :version "23.1" ;; No Gnus
+  :group 'gnus-summary
+  :type '(radio (const :tag "None" nil) (string :tag "Command")))
+
 (defcustom gnus-summary-muttprint-program "muttprint"
   "Command (and optional arguments) used to run Muttprint."
   :version "22.1"
@@ -11612,7 +11619,9 @@
   (interactive (gnus-interactive "P\ny"))
   (require 'gnus-art)
   (let ((gnus-default-article-saver 'gnus-summary-save-in-pipe)
-	(gnus-save-all-headers (or headers gnus-save-all-headers)))
+	(gnus-save-all-headers (or headers gnus-save-all-headers))
+	(gnus-last-shell-command (or gnus-summary-pipe-output-default-command
+				     gnus-last-shell-command)))
     (gnus-summary-save-article arg t))
   (let ((buffer (get-buffer "*Shell Command Output*")))
     (when (and buffer