From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/62487 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: BUG: 'configure' doesn't preserve spaces in directory path; fixes Date: Tue, 04 Apr 2006 08:37:10 +0900 Organization: Emacsen advocacy group Message-ID: References: <86slouae1h.fsf@PECTOPAH.shenton.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1144107703 21842 80.91.229.2 (3 Apr 2006 23:41:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 3 Apr 2006 23:41:43 +0000 (UTC) Cc: Chris Shenton Original-X-From: ding-owner+m11014@lists.math.uh.edu Tue Apr 04 01:41:39 2006 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FQYft-0001AC-R4 for ding-account@gmane.org; Tue, 04 Apr 2006 01:41:34 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1FQYfk-0000qb-00; Mon, 03 Apr 2006 18:41:24 -0500 Original-Received: from nas02.math.uh.edu ([129.7.128.40]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1FQYbv-0000qW-00 for ding@lists.math.uh.edu; Mon, 03 Apr 2006 18:37:27 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas02.math.uh.edu with esmtp (Exim 4.52) id 1FQYbr-0001Av-5g for ding@lists.math.uh.edu; Mon, 03 Apr 2006 18:37:27 -0500 Original-Received: from washington.hostforweb.net ([66.225.201.13]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1FQYbq-00079s-00 for ; Tue, 04 Apr 2006 01:37:22 +0200 Original-Received: from [205.234.185.198] (port=51791 helo=mail.jpl.org) by washington.hostforweb.net with esmtpa (Exim 4.52) id 1FQYcn-0007j1-WE; Mon, 03 Apr 2006 18:38:22 -0500 Original-To: ding@gnus.org X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/23.0.0 (gnu/linux) Cancel-Lock: sha1:aFyxqt2ahwAojcgoTXpoFYyZNK4= X-Hashcash: 1:20:060403:ding@gnus.org::ECfATnYNK1G/ht2d:00005VIc X-Hashcash: 1:20:060403:chris@shenton.org::VtysS+/LsIHR6Iib:00000000000000000000000000000000000000000000Hsam X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - washington.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -2.5 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:62487 Archived-At: Hi, First of all, should it be fixed even if there seem to be only a few days up to release? Though I have a solution. >>>>> In <86slouae1h.fsf@PECTOPAH.shenton.org> Chris Shenton wrote: > I'm building Gnus from CVS on OS X with Aquamacs Emacs. It's > installed in /Applications/Aquamacs Emacs.app; note the space. I can > do the config like: > ./configure --prefix=/Applications/Aquamacs\ Emacs.app/Contents/Resources > It breaks here: > checking where .elc files should go... ./configure: line 1547: test: > /Applications/Aquamacs: binary operator expected > ./configure: line 1547: test: /Applications/Aquamacs: binary operator > expected > $(datadir)/emacs/site-lisp/gnus > If I remove OS X stock /usr/bin/emacs and instead symlink it to > /Applications/Aquamacs\ Emacs.app and then do an configure (unadorned, > or with --prefix=/usr/local) it seems to work, but note the URL > version it finds: > ./configure --prefix=/usr/local > ... > checking for acceptable URL version... "/Applications/Aquamacs Emacs.app/Contents/Resources/lisp/url/" > ... > A "make" fails immediately: > URLDIR=/Applications/Aquamacs Emacs.app/Contents/Resources/lisp/url/ W3DIR=no lispdir=/usr/share/emacs/site-lisp/gnus srcdir=. emacs -batch -q -no-site-file -l ./dgnushack.el -f dgnushack-make-cus-load . > /bin/sh: line 1: Emacs.app/Contents/Resources/lisp/url/: No such file or directory > If I quote the dirs in ./lisp/Makefile like the following, it works: > EMACS_COMP = URLDIR="$(URLDIR)" W3DIR="$(W3DIR)" lispdir="$(lispdir)" srcdir="$(srcdir)" $(EMACS) $(FLAGS) > I'm not really familiar with "configure", but the following patch got > it to work for me using > --prefix="/Applications/Aquamacs Emacs.app/Contents/Resources > *** configure.~7.3.~ Tue Oct 4 05:38:54 2005 > --- configure Mon Apr 3 11:02:49 2006 > *************** > *** 1125,1131 **** > CONFIG_SITE="$ac_default_prefix/share/config.site $ac_default_prefix/etc/config.site" > fi > fi > ! for ac_site_file in $CONFIG_SITE; do > if test -r "$ac_site_file"; then > { echo "$as_me:$LINENO: loading site script $ac_site_file" >&5 > echo "$as_me: loading site script $ac_site_file" >&6;} > --- 1125,1131 ---- > CONFIG_SITE="$ac_default_prefix/share/config.site $ac_default_prefix/etc/config.site" > fi > fi > ! for ac_site_file in "$CONFIG_SITE"; do > if test -r "$ac_site_file"; then > { echo "$as_me:$LINENO: loading site script $ac_site_file" >&5 > echo "$as_me: loading site script $ac_site_file" >&6;} > *************** > *** 1544,1550 **** > fi > for thedir in share lib; do > potential= > ! if test -d ${theprefix}/${thedir}/${EMACS_FLAVOR}/site-lisp; then > if test "$EMACS_FLAVOR" = "xemacs"; then > lispdir="\$(prefix)/${thedir}/${EMACS_FLAVOR}/site-packages/lisp/gnus" > else > --- 1544,1550 ---- > fi > for thedir in share lib; do > potential= > ! if test -d "${theprefix}/${thedir}/${EMACS_FLAVOR}/site-lisp"; then > if test "$EMACS_FLAVOR" = "xemacs"; then > lispdir="\$(prefix)/${thedir}/${EMACS_FLAVOR}/site-packages/lisp/gnus" > else Your patch solves two problems. One is due to the AC_SITE_LOAD macro defined in autoconf, the other is caused by the AC_PATH_LISPDIR macro defined in aclocal.m4 which Gnus provides. I don't think modifying the configure script is a good idea because it should be generated automatically by autoconf. Instead, my solution which modifies Gnus' aclocal.m4 is below. However, I'm not sure whether redefining the AC_SITE_LOAD macro is a right way. Anyone? --- aclocal.m4~ 2005-10-04 08:37:27 +0000 +++ aclocal.m4 2006-04-03 23:35:24 +0000 @@ -91,7 +91,8 @@ fi for thedir in share lib; do potential= - if test -d ${theprefix}/${thedir}/${EMACS_FLAVOR}/site-lisp; then + dnl The directory name should be quoted because it might contain spaces. + if test -d "${theprefix}/${thedir}/${EMACS_FLAVOR}/site-lisp"; then if test "$EMACS_FLAVOR" = "xemacs"; then lispdir="\$(prefix)/${thedir}/${EMACS_FLAVOR}/site-packages/lisp/gnus" else @@ -322,6 +323,28 @@ AC_SUBST(USE_FONTS) ]) +# Redefine AC_SITE_LOAD which is originally defined in general.m4. +# ---------------------------------------------------------------- +# Look for site or system specific initialization scripts. +m4_define([AC_SITE_LOAD], +[# Prefer explicitly selected file to automatically selected ones. +if test -z "$CONFIG_SITE"; then + if test "x$prefix" != xNONE; then + CONFIG_SITE="$prefix/share/config.site $prefix/etc/config.site" + else + CONFIG_SITE="$ac_default_prefix/share/config.site $ac_default_prefix/etc/config.site" + fi +fi +dnl $CONFIG_SITE should be quoted because the value might contain spaces. +for ac_site_file in "$CONFIG_SITE"; do + if test -r "$ac_site_file"; then + AC_MSG_NOTICE([loading site script $ac_site_file]) + sed 's/^/| /' "$ac_site_file" >&AS_MESSAGE_LOG_FD + . "$ac_site_file" + fi +done +]) + ifelse(dnl Do not change this comment arch-tag: 5c987641-c3ef-4f12-b067-028302282c66 )dnl