Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
Subject: Re: PATCH: Make nnrss fail gracefully when it can't fetch a feed
Date: Thu, 22 Dec 2005 12:38:01 +0900	[thread overview]
Message-ID: <b4mfyoln6na.fsf_-_@jpl.org> (raw)
In-Reply-To: <87y82e1gg2.fsf@stone.tss.usg.edu>

>>>>> In <87y82e1gg2.fsf@stone.tss.usg.edu> Mark Plaksin wrote:

> When nnrss can't fetch a feed an error is signalled.  This patch makes
> nnrss print a warning instead.

> When you use 'g' from the Group buffer, the current behavior prevents the
> rest of your feeds from being checked.  The root cause is the use of
> `(error)' in mm-url-insert-file-contents-external.  This patch just adds a
> condition-case in nnrss.el.

> -	  (mm-url-insert url)))
> +          (condition-case nil
> +              (mm-url-insert url)
> +            (error (nnheader-message 3 "nnrss: Failed to fetch %s" url)))))

Isn't it better to use just `message' since it is obviously an
error?  And also (sit-for N) might be required.

> I don't know whether I used the right -message function.  What's the
> difference between nnheader-message and gnus-message?

AFAIK, gnus- modules, mm- modules, nn- modules, and others are
mutually independent.  For example, there might be people who
use nn- modules for the application other than Gnus. (They
depend each other in practice, though.)

BTW, you'd better do the paper work for the copyright assignment
on Emacs (or Gnus) because the remainder of your `tiny change'
quota will be used up sooner or later. ;-)



  parent reply	other threads:[~2005-12-22  3:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-21 17:57 Mark Plaksin
2005-12-21 18:28 ` Mark Plaksin
2005-12-22  3:38 ` Katsumi Yamaoka [this message]
2005-12-22 13:50   ` Mark Plaksin
2005-12-22 14:49     ` Katsumi Yamaoka
2005-12-31 15:49       ` Mark Plaksin
2006-01-01  6:46         ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4mfyoln6na.fsf_-_@jpl.org \
    --to=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).