From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/61599 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: PATCH: Make nnrss fail gracefully when it can't fetch a feed Date: Thu, 22 Dec 2005 12:38:01 +0900 Organization: Emacsen advocacy group Message-ID: References: <87y82e1gg2.fsf@stone.tss.usg.edu> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1135224372 21923 80.91.229.2 (22 Dec 2005 04:06:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 22 Dec 2005 04:06:12 +0000 (UTC) Original-X-From: ding-owner+m10131@lists.math.uh.edu Thu Dec 22 05:06:10 2005 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EpHiP-0000Em-5B for ding-account@gmane.org; Thu, 22 Dec 2005 05:06:05 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1EpHiK-0005o8-00; Wed, 21 Dec 2005 22:06:00 -0600 Original-Received: from nas01.math.uh.edu ([129.7.128.39]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1EpHiE-0005o3-00 for ding@lists.math.uh.edu; Wed, 21 Dec 2005 22:05:54 -0600 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas01.math.uh.edu with esmtp (Exim 4.52) id 1EpHiC-0003mr-OF for ding@lists.math.uh.edu; Wed, 21 Dec 2005 22:05:54 -0600 Original-Received: from washington.hostforweb.net ([66.225.201.13]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1EpHHK-0008Hd-00 for ; Thu, 22 Dec 2005 04:38:06 +0100 Original-Received: from localhost ([127.0.0.1]:48020) by washington.hostforweb.net with esmtpa (Exim 4.52) id 1EpHIz-0006FY-Qw for ding@gnus.org; Wed, 21 Dec 2005 21:39:50 -0600 Original-To: ding@gnus.org X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/22.0.50 (gnu/linux) Cancel-Lock: sha1:4qZq9YGecMiZCgnH0kK6vAstk4Y= X-Hashcash: 1:20:051222:ding@gnus.org::gnojNj8fBhnDwG+N:00001ugT X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - washington.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -2.5 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:61599 Archived-At: >>>>> In <87y82e1gg2.fsf@stone.tss.usg.edu> Mark Plaksin wrote: > When nnrss can't fetch a feed an error is signalled. This patch makes > nnrss print a warning instead. > When you use 'g' from the Group buffer, the current behavior prevents the > rest of your feeds from being checked. The root cause is the use of > `(error)' in mm-url-insert-file-contents-external. This patch just adds a > condition-case in nnrss.el. > - (mm-url-insert url))) > + (condition-case nil > + (mm-url-insert url) > + (error (nnheader-message 3 "nnrss: Failed to fetch %s" url))))) Isn't it better to use just `message' since it is obviously an error? And also (sit-for N) might be required. > I don't know whether I used the right -message function. What's the > difference between nnheader-message and gnus-message? AFAIK, gnus- modules, mm- modules, nn- modules, and others are mutually independent. For example, there might be people who use nn- modules for the application other than Gnus. (They depend each other in practice, though.) BTW, you'd better do the paper work for the copyright assignment on Emacs (or Gnus) because the remainder of your `tiny change' quota will be used up sooner or later. ;-)