Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: bugs@gnus.org, ding@gnus.org, emacs-devel@gnu.org
Subject: Re: Why multibyte for original-article buffer
Date: Fri, 29 Feb 2008 09:35:30 +0900	[thread overview]
Message-ID: <b4mhcfsa9bh.fsf@jpl.org> (raw)
In-Reply-To: <jwvd4qg3nfg.fsf-monnier+emacs@gnu.org>

>>>>> Stefan Monnier wrote:

> I've been running with the following patch with good results.
> Also the patch makes sense to me: the original article is a sequence of
> bytes (i.e. encoded chars), so a unibyte buffer makes a lot of sense
> (it's more efficient and is likely to hide fewer bugs).

So, it is better to make also the " *nntpd*" buffer, the process
buffer for pop3, etc. be unibyte.  If such changes cause a problem,
it will be due to a code that copies data from those buffers to
a multibyte buffer and then decodes the data.  Actually, making
the original article buffer be unibyte prevents me from reading
a Japanese 8bit shift_jis message like this.

日本語

(Try `g' in the summary buffer.)

> Yet the code currently explicitly sets the buffer to multibyte mode.
> Does anybody know why?

IIRC, it was done about ten years ago.  I guess it was probably
a workaround for a problem like the one mentioned above.

> --- gnus-art.el.~1.154.~	2008-02-28 14:10:39.000000000 -0500
> +++ gnus-art.el	2008-02-28 14:09:51.000000000 -0500
> @@ -4342,7 +4342,7 @@
>      (gnus-article-setup-highlight-words)
>      ;; Init original article buffer.
>      (with-current-buffer (gnus-get-buffer-create gnus-original-article-buffer)
> -      (mm-enable-multibyte)
> +      (mm-disable-multibyte)
>        (setq major-mode 'gnus-original-article-mode)
>        (make-local-variable 'gnus-original-article))
>      (if (and (get-buffer name)

It is beyond my capacity to verify (and possibly to fix) all the
Gnus codes that copy data from there to somewhere.

Regards,




       reply	other threads:[~2008-02-29  0:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <jwvd4qg3nfg.fsf-monnier+emacs@gnu.org>
2008-02-29  0:35 ` Katsumi Yamaoka [this message]
2008-02-29  4:22   ` Stefan Monnier
2008-02-29  5:44     ` Katsumi Yamaoka
2008-02-29  6:18       ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4mhcfsa9bh.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=bugs@gnus.org \
    --cc=ding@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).