copy-list, equalp

copy-list, equalp

[Katsumi Yamaoka]

Lars Magne Ingebrigtsen wrote:
> - Log -----------------------------------------------------------------
> commit 486da4d5d54814a27e7525d59e8c2327631f9061
> Author: Lars Magne Ingebrigtsen <larsi@quimbies.gnus.org>
> Date:   Sun Sep 19 17:02:02 2010 +0200
[...]
> +(defun gnus-methods-sloppily-equal (m1 m2)
[...]
> +    (let ((p1 (copy-list (cddr m1)))
> +	  (p2 (copy-list (cddr m2)))
[...]
> +	  (unless (equalp e1 e2)

Please don't use cl run-time functions (used in
`gnus-sloppily-equal-method-parameters' now).

Re: copy-list, equalp

[Ted Zlatanov]

On Fri, 24 Sep 2010 10:26:11 +0900 Katsumi Yamaoka <yamaoka@jpl.org> wrote: 

KY> Please don't use cl run-time functions (used in
KY> `gnus-sloppily-equal-method-parameters' now).

Is that a problem with the run-time or CL in general?

Ted

Re: copy-list, equalp

[Lars Magne Ingebrigtsen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> Please don't use cl run-time functions (used in
> `gnus-sloppily-equal-method-parameters' now).

Thanks for catching this.  Fixed and pushed.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: copy-list, equalp

[Lars Magne Ingebrigtsen]

Ted Zlatanov <tzz@lifelogs.com> writes:

> Is that a problem with the run-time or CL in general?

We're Not Allowed to use the cl.el functions run-time.  But we can use
the macros from cl-macs.el. 

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: copy-list, equalp

[Ted Zlatanov]

On Fri, 24 Sep 2010 17:58:55 +0200 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote: 

LMI> Ted Zlatanov <tzz@lifelogs.com> writes:
>> Is that a problem with the run-time or CL in general?

LMI> We're Not Allowed to use the cl.el functions run-time.  But we can use
LMI> the macros from cl-macs.el. 

What a shame.  I think they're often easier and more intuitive than the
ELisp equivalents.

Ted