From: Katsumi Yamaoka <yamaoka@jpl.org>
To: ding@gnus.org
Subject: Re: [PATCH] Fix gnus-message-citation-mode for (S)XEmacs
Date: Thu, 08 Feb 2007 13:42:02 +0900 [thread overview]
Message-ID: <b4mk5yt45wl.fsf@jpl.org> (raw)
In-Reply-To: <m1abzq6kzh.fsf@davestoy.homelinux.org>
>>>>> In <m1abzq6kzh.fsf@davestoy.homelinux.org> Dave Goldberg wrote:
>>>>>> On Wed, 07 Feb 2007 18:25:02 +0900, Katsumi Yamaoka <yamaoka@jpl.org> said:
>> I've made changes in the trunk so that this feature may work
>> even with XEmacs 21.4/5 and SXEmacs (it cannot have worked with
>> XEmacs 21.5 even if `font-lock-add-keywords' is available). Now
>> `gnus-message-highlight-citation' always defaults to t.
> Unfortunately with this change (I'm assuming) I lost all highlighting
> in message mode unless I specifically set g-m-h-c to nil.
> XEmacs 21.4 (patch 19) "Constant Variable" [Lucid] (i686-pc-linux, Mule) of Mon Mar 20 2006 on davestoy.homelinux.org
I don't know why I saw it having worked with XEmacs yesterday
(it might have been due to `lazy-shot'). But it should not have
worked because of a bug. Sorry.
Emacs uses the `(t KEYWORDS COMPILED...)' form for compiled
font-lock keywords while XEmacs uses the `(t COMPILED...)' form.
However, in XEmacs 21.5, `font-lock-add-keywords' and
`font-lock-remove-keywords' assume the form of the Emacs style
for compiled keywords mistakenly. Because those function
definitions are now the same as the ones in Emacs 22. And I
partially copied them for XEmacs 21.4 and SXEmacs from XEmacs
21.5 into gnus-cite.el.
I've added the test checking `f-l-add-k' and `f-l-remove-k' that
XEmacs provide work correctly. I've also fixed the emulating
version of them. Currently not only 21.4 but also XEmacs 21.5
uses them. Could you try the latest CVS?
Regards,
next prev parent reply other threads:[~2007-02-08 4:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-31 7:18 Steve Youngs
2006-12-31 11:52 ` Reiner Steib
2007-01-01 7:26 ` Katsumi Yamaoka
2007-02-07 9:25 ` Katsumi Yamaoka
2007-02-07 15:33 ` Dave Goldberg
2007-02-08 4:42 ` Katsumi Yamaoka [this message]
2007-02-08 17:48 ` Dave Goldberg
2007-02-08 23:29 ` Katsumi Yamaoka
2007-02-13 12:46 ` Katsumi Yamaoka
2007-02-13 19:49 ` Dave Goldberg
2007-02-14 0:29 ` Katsumi Yamaoka
2007-02-28 21:14 ` Dave Goldberg
2007-02-28 22:32 ` Katsumi Yamaoka
2007-03-01 16:29 ` Dave Goldberg
2007-03-02 15:28 ` Dave Goldberg
2007-02-09 23:48 ` Steve Youngs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4mk5yt45wl.fsf@jpl.org \
--to=yamaoka@jpl.org \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).