From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/64288 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH] Fix gnus-message-citation-mode for (S)XEmacs Date: Thu, 08 Feb 2007 13:42:02 +0900 Organization: Emacsen advocacy group Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 X-Trace: sea.gmane.org 1170909860 15357 80.91.229.12 (8 Feb 2007 04:44:20 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 8 Feb 2007 04:44:20 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M12811@lists.math.uh.edu Thu Feb 08 05:44:07 2007 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1HF18h-0006sW-30 for ding-account@gmane.org; Thu, 08 Feb 2007 05:44:07 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1HF176-0006d9-Ob; Wed, 07 Feb 2007 22:42:28 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1HF175-0006co-8A for ding@lists.math.uh.edu; Wed, 07 Feb 2007 22:42:27 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.63) (envelope-from ) id 1HF16z-0001PY-0A for ding@lists.math.uh.edu; Wed, 07 Feb 2007 22:42:27 -0600 Original-Received: from orlando.hostforweb.net ([216.246.45.90]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1HF16x-0004p6-00 for ; Thu, 08 Feb 2007 05:42:20 +0100 Original-Received: from [66.225.201.151] (port=38504 helo=mail.jpl.org) by orlando.hostforweb.net with esmtpa (Exim 4.63) (envelope-from ) id 1HF172-0001xG-4m for ding@gnus.org; Wed, 07 Feb 2007 22:42:24 -0600 X-Hashcash: 1:20:070208:ding@gnus.org::8NvNYI8ctSECW3hF:00008vtC X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110006 (No Gnus v0.6) XEmacs/21.5-b27 (linux) Cancel-Lock: sha1:OZ7mUo59y1lKmHlVVZW2SKT0cdI= X-Antivirus-Scanner: Clean mail though you should still use an Antivirus X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [0 0] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -2.5 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:64288 Archived-At: >>>>> In Dave Goldberg wrote: >>>>>> On Wed, 07 Feb 2007 18:25:02 +0900, Katsumi Yamaoka said: >> I've made changes in the trunk so that this feature may work >> even with XEmacs 21.4/5 and SXEmacs (it cannot have worked with >> XEmacs 21.5 even if `font-lock-add-keywords' is available). Now >> `gnus-message-highlight-citation' always defaults to t. > Unfortunately with this change (I'm assuming) I lost all highlighting > in message mode unless I specifically set g-m-h-c to nil. > XEmacs 21.4 (patch 19) "Constant Variable" [Lucid] (i686-pc-linux, Mule) of Mon Mar 20 2006 on davestoy.homelinux.org I don't know why I saw it having worked with XEmacs yesterday (it might have been due to `lazy-shot'). But it should not have worked because of a bug. Sorry. Emacs uses the `(t KEYWORDS COMPILED...)' form for compiled font-lock keywords while XEmacs uses the `(t COMPILED...)' form. However, in XEmacs 21.5, `font-lock-add-keywords' and `font-lock-remove-keywords' assume the form of the Emacs style for compiled keywords mistakenly. Because those function definitions are now the same as the ones in Emacs 22. And I partially copied them for XEmacs 21.4 and SXEmacs from XEmacs 21.5 into gnus-cite.el. I've added the test checking `f-l-add-k' and `f-l-remove-k' that XEmacs provide work correctly. I've also fixed the emulating version of them. Currently not only 21.4 but also XEmacs 21.5 uses them. Could you try the latest CVS? Regards,