From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/67486 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.gnus.general Subject: Re: gnus-article-read-summary-keys: can't handle hidden summary buffer? Date: Tue, 30 Sep 2008 08:55:03 +0900 Organization: Emacsen advocacy group Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1222732577 5480 80.91.229.12 (29 Sep 2008 23:56:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Sep 2008 23:56:17 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M15937@lists.math.uh.edu Tue Sep 30 01:57:14 2008 connect(): Connection refused Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1KkSbz-0006aw-Nh for ding-account@gmane.org; Tue, 30 Sep 2008 01:57:08 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1KkSai-000819-3h; Mon, 29 Sep 2008 18:55:48 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1KkSag-00080y-VQ for ding@lists.math.uh.edu; Mon, 29 Sep 2008 18:55:46 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1KkSad-0000z0-RC for ding@lists.math.uh.edu; Mon, 29 Sep 2008 18:55:46 -0500 Original-Received: from orlando.hostforweb.net ([216.246.45.90]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1KkSai-0001dh-00 for ; Tue, 30 Sep 2008 01:55:48 +0200 Original-Received: from localhost ([127.0.0.1]:48451) by orlando.hostforweb.net with esmtpa (Exim 4.69) (envelope-from ) id 1KkSa1-0006BW-36 for ding@gnus.org; Mon, 29 Sep 2008 18:55:05 -0500 X-Hashcash: 1:20:080929:ding@gnus.org::m8tjd4sOI2ApbSdE:00000/rx X-Face: #kKnN,xUnmKia.'[pp`;Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu;B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:9dUw2pAB7xdaUWNP4btTe2lXJl8= X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - gnus.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:67486 Archived-At: >>>>> miles.bader@necel.com wrote: > Katsumi Yamaoka writes: >> Could you test this patch? > That seems to fix the problem. Installed in the Gnus trunk. >> Even in the case where the summary buffer is hidden, the summary >> window appears a moment (it is necessary for running a summary >> command) > I do notice some weird redisplay glitches where if something happens to > cause redisplay (e.g. a garbage-collection message), the summary buffer > will show up temporarily. Kind of annoying but... > Why is the summary window necessary for running a summary command? > Can't they just act on the summary buffer? > Thanks, To be exact, what is really necessary is to restore the window configuration after executing a summary command. It is because many summary commands run `(gnus-configure-windows 'article)' which sets the window layout according to the variable `gnus-buffer-configuration'. For instance, the N command runs it by way of `gnus-summary-next-article', `gnus-summary-display-article' and `gnus-article-prepare', and the summary window will appear. Try this in the article buffer: (progn (delete-other-windows) (sit-for 1) (with-current-buffer gnus-article-current-summary (gnus-summary-next-article))) So even if `gnus-article-read-summary-keys' is made not to display the summary window, it will be done by the others. Probably the present way was easy to coding. In addition to this, it seems to have been also necessary to handle the optional argument `not-restore-window' for the commands that do not display the summary window. I don't know what they were since that option is never used now, though. Anyway I think there is still room for improvement in `gnus-article-read-summary-keys'. To do at the beginning will be to remove the `not-restore-window' option. Regards,