Re: Bad header deconding in supersede

Re: Bad header deconding in supersede

[Katsumi Yamaoka]

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]

>>>>> Erwan David wrote:
> No Gnus v0.11
> GNU Emacs 22.2.1 (x86_64-pc-freebsd, X toolkit, Xaw3d scroll bars)
>  of 2008-06-09 on nez-casse.depot.rail.eu.org
> 200 news-3.free.fr (4-2) NNRP Service Ready - newsmaster@proxad.net (posting ok)

> When I supersede an article, whose headers where sent in ISO-8859-1, they
> are presented as is, thus as \351 since it is not a valid utf-8
> character. This leads to wrong encoding in superseded message header
> when I do not catch this.

> There is no problem in the body treatment, only headers.

There's a similar problem in `gnus-summary-resend-message-edit'
and the patch attached below seems to solve it.  However I don't
want to install it now because it has to be verified further and
the next Emacs (containing Gnus v5.13, a.k.a. No Gnus) release
is around the corner.  So I'd add it to my TODO list instead.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 719 bytes --]

--- gnus-msg.el~	2008-06-11 21:40:58 +0000
+++ gnus-msg.el	2008-08-05 09:53:51 +0000
@@ -1283,6 +1283,7 @@
 	;; Get a normal message buffer.
 	(message-pop-to-buffer (message-buffer-name "Resend" to))
 	(insert-buffer-substring cur)
+	(article-decode-encoded-words)
 	(mime-to-mml)
 	(message-narrow-to-head-1)
 	;; Gnus will generate a new one when sending.
--- message.el~	2008-07-17 23:44:34 +0000
+++ message.el	2008-08-05 09:53:51 +0000
@@ -6838,6 +6838,7 @@
     ;; Get a normal message buffer.
     (message-pop-to-buffer (message-buffer-name "supersede"))
     (insert-buffer-substring cur)
+    (article-decode-encoded-words)
     (mime-to-mml)
     (message-narrow-to-head-1)
     ;; Remove unwanted headers.

Re: Bad header deconding in supersede

[Katsumi Yamaoka]

>>>>> Katsumi Yamaoka wrote:
>>>>>> Erwan David wrote:
>> No Gnus v0.11
>> GNU Emacs 22.2.1 (x86_64-pc-freebsd, X toolkit, Xaw3d scroll bars)
>>  of 2008-06-09 on nez-casse.depot.rail.eu.org
>> 200 news-3.free.fr (4-2) NNRP Service Ready - newsmaster@proxad.net (posting ok)

>> When I supersede an article, whose headers where sent in ISO-8859-1, they
>> are presented as is, thus as \351 since it is not a valid utf-8
>> character. This leads to wrong encoding in superseded message header
>> when I do not catch this.

>> There is no problem in the body treatment, only headers.

> There's a similar problem in `gnus-summary-resend-message-edit'
> and the patch attached below seems to solve it.  However I don't
> want to install it now because it has to be verified further and
> the next Emacs (containing Gnus v5.13, a.k.a. No Gnus) release
> is around the corner.  So I'd add it to my TODO list instead.

I found a better and reasonable way to fix the problem, and
installed in the Gnus CVS trunk.  That it does is similar to
what Gnus does when reading articles.  Namely it decodes non-
MIME encoded text[1] in the header by `gnus-newsgroup-charset'.
I believe this is the right bug fix.

Regards,

[1] Non-MIME encoded text will be found in articles posted to
    certain newsgroups where RFC2047 encoding is unwelcome.
    In Gnus, `gnus-group-posting-charset-alist' specifies such
    newsgroups and charsets.