Gnus development mailing list
 help / color / mirror / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: ding@gnus.org
Subject: Re: Avoiding compiler warnings
Date: Thu, 06 Dec 2007 08:25:09 +0900	[thread overview]
Message-ID: <b4mlk88k9m2.fsf@jpl.org> (raw)
In-Reply-To: <v9wsrsucl6.fsf@marauder.physik.uni-ulm.de>

>>>>> Reiner Steib wrote:

> On Wed, Dec 05 2007, Katsumi Yamaoka wrote on ding-patches:
[...]
>> -			      (executable-find idna-program))
>> +			      (executable-find (symbol-value 'idna-program)))
>> -	       (directory-file-name installation-directory))
>> +	       (directory-file-name (symbol-value 'installation-directory)))
[...]

> Hm, IIRC last time we discussed this on emacs-devel, we decided not
> to obscurify the code for the sake of calming the byte compiler.

Agreed.  To lower the performance is not my real intention, so
I'll make those changes revert.

> Additionally...

> ,----[ (info "(gnus)Emacs/XEmacs Code") ]
>|    This means that Gnus will byte-compile under Emacs with nary a
>| warning, while XEmacs will pump out gigabytes of warnings while
>| byte-compiling.  [...]
> `----

This follows:
,----
|                  As I use byte-compilation warnings to help me root out
| trivial errors in Gnus, that's very useful.
`----

That byte-compilation doesn't report on harmless things is also
useful at least for me.  I do `make' with all versions of Emacsen
that Gnus supports whenever a change has been made in Gnus, and
check the source code if the byte compiler issues a warning.
Though no-warning doesn't mean there's no problem of course, it
is useful for such a work.  Is it acceptable to do things to
suppress warnings at lpath,el and dgnushack.el?



  reply	other threads:[~2007-12-05 23:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1IzjR8-0001ME-00@quimby.gnus.org>
2007-12-05 20:10 ` Avoiding compiler warnings (was: Changes committed gnus/lisp (6 files)) Reiner Steib
2007-12-05 23:25   ` Katsumi Yamaoka [this message]
2007-12-07  4:34     ` Avoiding compiler warnings Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4mlk88k9m2.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).