From: Katsumi Yamaoka <yamaoka@jpl.org>
To: ding@gnus.org
Subject: Re: gnus-uu bug?
Date: Thu, 19 Dec 2013 13:41:35 +0900 [thread overview]
Message-ID: <b4mmwjxjvuo.fsf@jpl.org> (raw)
In-Reply-To: <b4mob4eppnk.fsf@jpl.org>
Katsumi Yamaoka wrote:
> I came across many forwardxxxxxxx files left in the TMP directory.
> Where xxxxxxx is a unique alphanumeric characters and TMP is a
> directory that the user option `gnus-uu-tmp-dir' specifies, and
> those files are all empty. They should have been deleted, shouldn't
> they?
> I looked into the code and realized that such a file was created
> when I forwarded two or more articles in a single message. Whereas
> other gnus-uu files are created in the `gnus-uu-work-dir' directory,
> and are deleted when exiting a group.
> In relation to this, `gnus-uu-decode-binhex' and
> `gnus-uu-decode-binhex-view' seem to try to run without initializing
> `gnus-uu-work-dir'. I have no binhex data, so I haven't fully
> tested them, though.
In addition, it uses `gnus-exit-group-hook' to delete temporary
files when exiting a group, however `gnus-exit-group-hook' is not
evaluated when the group is an nnir group. It is because nnir
uses `gnus-group-read-ephemeral-group', that sets the quit-config
parameter for the group, to create a group. So, I've replaced
the hook with `gnus-summary-prepare-exit-hook' that is always run
by both `gnus-summary-exit' and `gnus-summary-exit-no-update'.
> May I commit this patch?
Maybe it was needless to ask people. Committed.
prev parent reply other threads:[~2013-12-19 4:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 7:46 Katsumi Yamaoka
2013-12-19 4:41 ` Katsumi Yamaoka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4mmwjxjvuo.fsf@jpl.org \
--to=yamaoka@jpl.org \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).