Re: [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-regexp): Fix default value.

Re: [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-regexp): Fix default value.

[Sven Joachim]

On 2010-11-09 03:00 +0100, Katsumi Yamaoka wrote:

> diff --git a/lisp/message.el b/lisp/message.el
> index 9b5f63c..035ba1c 100644
> --- a/lisp/message.el
> +++ b/lisp/message.el
> @@ -341,14 +341,14 @@ It is okay to create some false positives here, as the user is asked."
>    :type 'regexp)
>  
>  (defcustom message-subject-trailing-was-regexp
> -  "[ \t]*\\((*[Ww][Aa][Ss]:[ \t]*.*)\\)"
> +  "[ \t]*\\((*[Ww][Aa][Ss][ \t]*.*)\\)"
>    "*Regexp matching \"(was: <old subject>)\" in the subject line.

This looks suspicious.  The new value of
message-subject-trailing-was-regexp matches neither the docstring nor
what message-change-subject inserts when you change subject.  I would
suggest an optional colon both here and in
message-subject-trailing-was-ask-regexp:

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/message.el b/lisp/message.el
index 035ba1c..3dd4464 100644
--- a/lisp/message.el
+++ b/lisp/message.el
@@ -326,7 +326,7 @@ used."
   :group 'message-various)
 
 (defcustom message-subject-trailing-was-ask-regexp
-  "[ \t]*\\([[(]+[Ww][Aa][Ss][ \t]*.*[\])]+\\)"
+  "[ \t]*\\([[(]+[Ww][Aa][Ss]:?[ \t]*.*[\])]+\\)"
   "*Regexp matching \"(was: <old subject>)\" in the subject line.
 
 The function `message-strip-subject-trailing-was' uses this regexp if
@@ -335,13 +335,13 @@ the variable is t instead of `ask', use
 `message-subject-trailing-was-regexp' instead.
 
 It is okay to create some false positives here, as the user is asked."
-  :version "22.1"
+  :version "24.1"
   :group 'message-various
   :link '(custom-manual "(message)Message Headers")
   :type 'regexp)
 
 (defcustom message-subject-trailing-was-regexp
-  "[ \t]*\\((*[Ww][Aa][Ss][ \t]*.*)\\)"
+  "[ \t]*\\((*[Ww][Aa][Ss]:?[ \t]*.*)\\)"
   "*Regexp matching \"(was: <old subject>)\" in the subject line.
 
 If `message-subject-trailing-was-query' is set to t, the subject is
--8<---------------cut here---------------end--------------->8---

Cheers,
       Sven

Re: [gnus git] branch master updated: =1= message.el (message-subject-trailing-

[Katsumi Yamaoka]

Sven Joachim wrote:
> On 2010-11-09 03:00 +0100, Katsumi Yamaoka wrote:
>>  (defcustom message-subject-trailing-was-regexp
>> -  "[ \t]*\\((*[Ww][Aa][Ss]:[ \t]*.*)\\)"
>> +  "[ \t]*\\((*[Ww][Aa][Ss][ \t]*.*)\\)"

> This looks suspicious.  The new value of
> message-subject-trailing-was-regexp matches neither the docstring nor
> what message-change-subject inserts when you change subject.  I would
> suggest an optional colon both here and in
> message-subject-trailing-was-ask-regexp:

Thanks.  I'll apply the patch later.
(I must go home right now. ;-)

Re: [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-regexp): Fix default value.

[Andreas Schwab]

Sven Joachim <svenjoac@gmx.de> writes:

>  (defcustom message-subject-trailing-was-ask-regexp
> -  "[ \t]*\\([[(]+[Ww][Aa][Ss][ \t]*.*[\])]+\\)"
> +  "[ \t]*\\([[(]+[Ww][Aa][Ss]:?[ \t]*.*[\])]+\\)"
                                           ^
That backslash looks suspicious, because it is effectively ignored.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-regexp): Fix default value.

[Lars Magne Ingebrigtsen]

Andreas Schwab <schwab@linux-m68k.org> writes:

>> +  "[ \t]*\\([[(]+[Ww][Aa][Ss]:?[ \t]*.*[\])]+\\)"
>                                            ^
> That backslash looks suspicious, because it is effectively ignored.

I've now removed it.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen